From: "Dmitry Kravkov" <dmitry@broadcom.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, "Eilon Greenstein" <eilong@broadcom.com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Bruce Allan" <bruce.w.allan@intel.com>,
"Carolyn Wyborny" <carolyn.wyborny@intel.com>,
"Don Skidmore" <donald.c.skidmore@intel.com>,
"Greg Rose" <gregory.v.rose@intel.com>,
"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>,
"Alex Duyck" <alexander.h.duyck@intel.com>,
"John Ronciak" <john.ronciak@intel.com>,
"Tushar Dave" <tushar.n.dave@intel.com>,
"Jitendra Kalsaria" <jitendra.kalsaria@qlogic.com>,
"Sony Chacko" <sony.chacko@qlogic.com>,
linux-driver@qlogic.com,
"John Fastabend" <john.r.fastabend@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Jacob Keller" <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
bhutchings@solarflare.com, eric.dumazet@gmail.com
Subject: Re: [PATCHv2-net-3.8 3/3] bnx2x: set gso_type
Date: Thu, 7 Feb 2013 15:37:24 +0200 [thread overview]
Message-ID: <1360244244.17835.1.camel@lb-tlvb-dmitry> (raw)
In-Reply-To: <b9413cd3577c7b544cd522a6eb8ae6b037b20da6.1360236441.git.mst@redhat.com>
On Thu, 2013-02-07 at 15:13 +0200, Michael S. Tsirkin wrote:
> In LRO mode, bnx2x set gso_size but not gso type.
> This leads to crashes in macvtap.
> Commit cbf1de72324a8105ddcc3d9ce9acbc613faea17e
> queued for 3.9 includes a more complete fix.
> This is a minimal patch to avoid the crash, for 3.8.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index f771ddf..a5edac8 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -504,13 +504,11 @@ static int bnx2x_fill_frag_skb(struct bnx2x *bp, struct bnx2x_fastpath *fp,
> skb_shinfo(skb)->gso_size = bnx2x_set_lro_mss(bp,
> tpa_info->parsing_flags, len_on_bd);
>
> - /* set for GRO */
> - if (fp->mode == TPA_MODE_GRO)
> - skb_shinfo(skb)->gso_type =
> - (GET_FLAG(tpa_info->parsing_flags,
> - PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) ==
> - PRS_FLAG_OVERETH_IPV6) ?
> - SKB_GSO_TCPV6 : SKB_GSO_TCPV4;
> + skb_shinfo(skb)->gso_type =
> + (GET_FLAG(tpa_info->parsing_flags,
> + PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) ==
> + PRS_FLAG_OVERETH_IPV6) ?
> + SKB_GSO_TCPV6 : SKB_GSO_TCPV4;
> }
>
>
Thanks!
Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
next prev parent reply other threads:[~2013-02-07 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 13:12 [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO Michael S. Tsirkin
2013-02-07 13:13 ` [PATCHv2-net-3.8 1/3] ixgbe: fix gso type Michael S. Tsirkin
2013-02-07 13:13 ` [PATCHv2-net-3.8 2/3] qlcnic: set gso_type Michael S. Tsirkin
2013-02-07 17:08 ` Jitendra Kalsaria
2013-02-07 13:13 ` [PATCHv2-net-3.8 3/3] bnx2x: " Michael S. Tsirkin
2013-02-07 13:37 ` Dmitry Kravkov [this message]
2013-02-07 17:05 ` [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO Ben Hutchings
2013-02-11 1:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360244244.17835.1.camel@lb-tlvb-dmitry \
--to=dmitry@broadcom.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sony.chacko@qlogic.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).