From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<netdev@vger.kernel.org>, <eilong@broadcom.com>,
<jeffrey.t.kirsher@intel.com>, <jesse.brandeburg@intel.com>,
<bruce.w.allan@intel.com>, <carolyn.wyborny@intel.com>,
<donald.c.skidmore@intel.com>, <gregory.v.rose@intel.com>,
<peter.p.waskiewicz.jr@intel.com>, <alexander.h.duyck@intel.com>,
<john.ronciak@intel.com>, <tushar.n.dave@intel.com>,
<jitendra.kalsaria@qlogic.com>, <sony.chacko@qlogic.com>,
<linux-driver@qlogic.com>, <john.r.fastabend@intel.com>,
<jacob.e.keller@intel.com>, <linux-kernel@vger.kernel.org>,
<e1000-devel@lists.sourceforge.net>
Subject: Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO
Date: Thu, 7 Feb 2013 22:31:35 +0000 [thread overview]
Message-ID: <1360276295.3605.44.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <20130207213315.GB5064@redhat.com>
On Thu, 2013-02-07 at 23:33 +0200, Michael S. Tsirkin wrote:
> On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> > From: Ben Hutchings <bhutchings@solarflare.com>
> > Date: Thu, 7 Feb 2013 16:20:46 +0000
> >
> > > If the consensus is still that we must preserve packets exactly (aside
> > > from the usual modifications by IP routers) then LRO should be disabled
> > > on all devices for which forwarding is enabled.
> >
> > I believe this is still undoubtedly the consensus.
>
> But we don't need to preserve the packets when passing them to macvtap
> (which discards all this info smashing the packet into a single buffer anyway),
> correct?
macvtap_skb_to_vnet_hdr() certainly seems to be trying to preserve all
the packet information.
> If true LRO with macvtap might be useful and so the patchset is probably
> still the right thing to do to fix the macvtap crash. Makes sense?
If macvtap+virtio_net is expected to re-segment then this is fine. But
I don't see why it should be different from other uses of macvlan.
> We might want to add code to forward LRO status from macvlan
> (not macvtap) back to the lowerdev, so that setting up forwarding
> from macvlan disables LRO on the lowerdev, but that seems like another
> issue.
I think it's the same issue!
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-02-07 22:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 23:02 [PATCH 0/2] fix kernel crash with macvtap on top of LRO Michael S. Tsirkin
2013-02-06 23:02 ` [PATCH 1/2] ixgbe: fix gso type Michael S. Tsirkin
2013-02-07 3:21 ` Eric Dumazet
2013-02-06 23:02 ` [PATCH 2/2] qlcnic: set gso_type Michael S. Tsirkin
2013-02-07 3:20 ` Eric Dumazet
2013-02-07 8:16 ` Michael S. Tsirkin
2013-02-06 23:34 ` [PATCH 0/2] fix kernel crash with macvtap on top of LRO Ben Hutchings
2013-02-07 3:18 ` Eric Dumazet
2013-02-07 16:20 ` Ben Hutchings
2013-02-07 18:14 ` David Miller
2013-02-07 21:33 ` Michael S. Tsirkin
2013-02-07 22:31 ` Ben Hutchings [this message]
2013-02-11 1:15 ` David Miller
2013-06-10 7:07 ` Michael S. Tsirkin
2013-06-12 14:56 ` Ben Hutchings
2013-06-12 19:00 ` Michael S. Tsirkin
2013-06-17 1:35 ` Rusty Russell
2013-06-17 16:20 ` Ben Hutchings
2013-06-18 5:12 ` Rusty Russell
2013-02-07 3:25 ` Cong Wang
2013-02-07 8:15 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360276295.3605.44.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sony.chacko@qlogic.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).