From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760333Ab3BHT25 (ORCPT ); Fri, 8 Feb 2013 14:28:57 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26010 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946826Ab3BHT2v (ORCPT ); Fri, 8 Feb 2013 14:28:51 -0500 From: Yinghai Lu To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Bjorn Helgaas , "Rafael J. Wysocki" Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu , Joerg Roedel , Donald Dutile Subject: [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi with local node Date: Fri, 8 Feb 2013 11:28:05 -0800 Message-Id: <1360351703-20571-9-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360351703-20571-1-git-send-email-yinghai@kernel.org> References: <1360351703-20571-1-git-send-email-yinghai@kernel.org> X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org iommu irq's irq_desc should be on local node ram. Fix the return value checking problem. create_irq() will return -1 when fail to allocate. create_irq_nr() will return 0 when fail to allocate. here only check !irq, so need to change it to use create_irq_nr instead. Signed-off-by: Yinghai Lu Cc: Joerg Roedel Cc: Donald Dutile --- drivers/iommu/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 174bb65..316b5a2 100644 --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c @@ -1263,7 +1263,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu) if (iommu->irq) return 0; - irq = create_irq(); + irq = create_irq_nr(0, iommu->node); if (!irq) { pr_err("IOMMU: no free vectors\n"); return -EINVAL; -- 1.7.10.4