From: Shuah Khan <shuah.khan@hp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Joerg Roedel <joro@8bytes.org>,
LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
iommu@lists.linux-foundation.org
Subject: Re: IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() in Linux 3.4
Date: Mon, 11 Feb 2013 13:57:03 -0700 [thread overview]
Message-ID: <1360616223.2950.15.camel@lorien2> (raw)
In-Reply-To: <20130211194901.GA18115@kroah.com>
On Mon, 2013-02-11 at 11:49 -0800, Greg KH wrote:
> On Wed, Feb 06, 2013 at 07:40:50PM -0700, Shuah Khan wrote:
> > On Wed, 2013-02-06 at 13:12 +0100, Joerg Roedel wrote:
> > > On Tue, Feb 05, 2013 at 06:57:21AM -0700, Shuah Khan wrote:
> > > > Thanks much. I will hang on to this test system for testing your fix.
> > >
> > > Okay, here is the simple fix for v3.8-rc6. I guess it is not
> > > straighforward to port it to v3.4, but it should be doable.
> > >
> > > From 2ecf57c85e67e0243b36b787d0490c0b47202ba8 Mon Sep 17 00:00:00 2001
> > > From: Joerg Roedel <joro@8bytes.org>
> > > Date: Wed, 6 Feb 2013 12:55:23 +0100
> > > Subject: [PATCH] iommu/amd: Initialize device table after dma_ops
> > >
> > > When dma_ops are initialized the unity mappings are
> > > created. The init_device_table_dma() function makes sure DMA
> > > from all devices is blocked by default. This opens a short
> > > window in time where DMA to unity mapped regions is blocked
> > > by the IOMMU. Make sure this does not happen by initializing
> > > the device table after dma_ops.
> > >
> > > Signed-off-by: Joerg Roedel <joro@8bytes.org>
> >
> > Joerg,
> >
> > I tested your patch on 3.8. I was able to reproduce the problem and then
> > apply your patch to verify that the problem is fixed. This patch applies
> > cleanly to 3.7.6, however I could not reproduce the problem on 3.7.6
> > without the patch. But the window exists on 3.7 as well. Your patch can
> > be applied to 3.7.6 as is.
> >
> > I back-ported the patch to 3.4 and 3.0 and tested. I am sending those
> > patches after this email.
> >
> > On 3.4.29 and 3.0.62 I was able to reproduce the problem and then
> > applied the back-ported patch to verify that the problem is fixed.
> >
> > Thanks again for the fix.
>
> I'm lost here, why isn't this patch in Linus's tree already? You seem
> to be sending backports for something that isn't there to backport yet.
>
> Please resend these patches to stable@vger.kernel.org, with the upstream
> git commit id, when they are in Linus's tree, there's nothing I can do
> with them for now, sorry.
>
> greg k-h
I was hoping Joerg's patch would make it into Linus's tree by now. I
tested the original patch and did the back-port to 3.4 and 3.0 at the
same time, before I loose the test system.
No worries. I will resend the patch when I have the commit id. Sorry for
the confusion.
Thanks,
-- Shuah
next prev parent reply other threads:[~2013-02-11 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:33 IO_PAGE_FAULTs on unity mapped regions during amd_iommu_init() in Linux 3.4 Shuah Khan
2013-02-01 13:00 ` Joerg Roedel
2013-02-01 18:31 ` Shuah Khan
2013-02-05 13:31 ` Joerg Roedel
2013-02-05 13:57 ` Shuah Khan
2013-02-06 12:12 ` Joerg Roedel
2013-02-07 2:40 ` Shuah Khan
2013-02-11 19:49 ` Greg KH
2013-02-11 20:17 ` Shuah Khan
2013-02-11 20:57 ` Shuah Khan [this message]
2013-02-11 22:18 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360616223.2950.15.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).