From: Steven Whitehouse <swhiteho@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled
Date: Tue, 12 Feb 2013 09:50:05 +0000 [thread overview]
Message-ID: <1360662605.2719.13.camel@menhir> (raw)
In-Reply-To: <alpine.DEB.2.02.1302111344140.14071@chino.kir.corp.google.com>
Hi,
On Mon, 2013-02-11 at 13:48 -0800, David Rientjes wrote:
> CONFIG_IP_SCTP relies on being able to select things like CONFIG_CRC32C to
> build. Thus, nothing should be selecting CONFIG_IP_SCTP that does not
> meet its requirements.
>
> For example, if CONFIG_EXPERIMENTAL is disabled and CONFIG_DLM is enabled,
> the build fails at link time:
>
> net/built-in.o: In function `sctp_crc32c':
> include/net/sctp/checksum.h:51: undefined reference to `crc32c'
> include/net/sctp/checksum.h:51: undefined reference to `crc32c'
> include/net/sctp/checksum.h:51: undefined reference to `crc32c'
> include/net/sctp/checksum.h:51: undefined reference to `crc32c'
> include/net/sctp/checksum.h:51: undefined reference to `crc32c'
> net/built-in.o:include/net/sctp/checksum.h:51: more undefined references to `crc32c' follow
>
> Fix this by making CONFIG_DLM depend on CONFIG_EXPERIMENTAL so that
> CONFIG_IP_SCTP properly builds.
>
That doesn't seem right to me... DLM has not been experimental for a
long time now. Why not just select CRC32 in addition to IP_SCTP ?
Steve.
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> fs/dlm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
> --- a/fs/dlm/Kconfig
> +++ b/fs/dlm/Kconfig
> @@ -2,6 +2,7 @@ menuconfig DLM
> tristate "Distributed Lock Manager (DLM)"
> depends on INET
> depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
> + depends on EXPERIMENTAL
> select IP_SCTP
> help
> A general purpose distributed lock manager for kernel or userspace
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-02-12 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 21:48 [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled David Rientjes
2013-02-12 9:50 ` Steven Whitehouse [this message]
2013-02-12 16:56 ` Linus Torvalds
2013-02-12 20:13 ` David Rientjes
2013-02-13 0:24 ` [patch for-3.8] net, sctp: remove CONFIG_EXPERIMENTAL David Rientjes
2013-02-13 9:53 ` Steven Whitehouse
2013-02-13 18:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360662605.2719.13.camel@menhir \
--to=swhiteho@redhat.com \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=teigland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).