From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933049Ab3BLK7H (ORCPT ); Tue, 12 Feb 2013 05:59:07 -0500 Received: from mga14.intel.com ([143.182.124.37]:3410 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933024Ab3BLK7E (ORCPT ); Tue, 12 Feb 2013 05:59:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,648,1355126400"; d="scan'208";a="201419208" From: Andy Shevchenko To: Vinod Koul , linux-kernel@vger.kernel.org, Viresh Kumar Cc: Andy Shevchenko , Linus Walleij , linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking Date: Tue, 12 Feb 2013 12:58:36 +0200 Message-Id: <1360666720-19006-4-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1360666720-19006-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1360666720-19006-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have not checked the code but there is a possibility that custom pool->lock is not needed at all due to dma_pool contains it's own lock. Signed-off-by: Andy Shevchenko Cc: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org --- drivers/dma/coh901318_lli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c index 3e96610..702112d 100644 --- a/drivers/dma/coh901318_lli.c +++ b/drivers/dma/coh901318_lli.c @@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len) dma_addr_t phy; if (len == 0) - goto err; + return NULL; spin_lock(&pool->lock); -- 1.7.10.4