From: Grant Likely <grant.likely@secretlab.ca>
To: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH v3 1/5] of/selftest: Fix GPIOs selftest to cover the 7th case
Date: Tue, 12 Feb 2013 23:06:37 +0000 [thread overview]
Message-ID: <1360710401-16757-2-git-send-email-grant.likely@secretlab.ca> (raw)
In-Reply-To: <1360710401-16757-1-git-send-email-grant.likely@secretlab.ca>
The of_gpio_named_count() self test doesn't hit the out-of-range
condition even though it is coded. Fix the bug by increasing the for
loop range by one.
Reported-by: Andreas Larsson <andreas@gaisler.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/of/selftest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/selftest.c b/drivers/of/selftest.c
index f24ffd7..9f62eb5 100644
--- a/drivers/of/selftest.c
+++ b/drivers/of/selftest.c
@@ -35,7 +35,7 @@ static void __init of_selftest_parse_phandle_with_args(void)
return;
}
- for (i = 0; i < 7; i++) {
+ for (i = 0; i < 8; i++) {
bool passed = true;
rc = of_parse_phandle_with_args(np, "phandle-list",
"#phandle-cells", i, &args);
--
1.7.10.4
next prev parent reply other threads:[~2013-02-12 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 23:06 [PATCH v3 0/5] of: Add helper for counting phandle refernces Grant Likely
2013-02-12 23:06 ` Grant Likely [this message]
2013-02-12 23:06 ` [PATCH v3 2/5] of/selftest: Use selftest() macro throughout Grant Likely
2013-02-12 23:06 ` [PATCH v3 3/5] of/base: Clean up exit paths for of_parse_phandle_with_args() Grant Likely
2013-02-12 23:06 ` [PATCH v3 4/5] of: Create function for counting number of phandles in a property Grant Likely
2013-02-13 9:57 ` Andreas Larsson
2013-02-12 23:06 ` [PATCH v3 5/5] gpio: Make of_count_named_gpios() use new of_count_phandle_with_args() Grant Likely
2013-02-13 10:00 ` Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360710401-16757-2-git-send-email-grant.likely@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).