From: Joe Perches <joe@perches.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Che-Liang Chiou <clchiou@chromium.org>,
Jonathan Kliegman <kliegs@chromium.org>,
Luigi Semenzato <semenzato@chromium.org>,
Olof Johansson <olofj@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation
Date: Tue, 12 Feb 2013 19:35:46 -0800 [thread overview]
Message-ID: <1360726546.2220.6.camel@joe-AO722> (raw)
In-Reply-To: <1360723347-28701-3-git-send-email-sjg@chromium.org>
On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote:
> This is the base EC implementation, which provides a high level
> interface to the EC for use by the rest of the kernel. The actual
> communcations is dealt with by a separate protocol driver which
> registers itself with this interface.
trivial logging message comments...
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
[]
> +struct cros_ec_device *cros_ec_alloc(const char *name)
> +{
> + struct cros_ec_device *ec_dev;
> +
> + ec_dev = kzalloc(sizeof(*ec_dev), GFP_KERNEL);
> + if (ec_dev == NULL) {
> + dev_err(ec_dev->dev, "cannot allocate\n");
allocation OOM messages aren't useful as there's
a standard one on all allocs without __GFP_WARN
> +int cros_ec_register(struct cros_ec_device *ec_dev)
> +{
[]
> + ec_dev->din = kmalloc(ec_dev->din_size, GFP_KERNEL);
> + if (!ec_dev->din) {
> + err = -ENOMEM;
> + dev_err(dev, "cannot allocate din\n");
etc...
> + if (err) {
> + dev_err(dev, "failed to add mfd devices");
missing terminating newline
next prev parent reply other threads:[~2013-02-13 3:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 2:42 [PATCH v2 0/6] Add ChromeOS Embedded Controller support Simon Glass
2013-02-13 2:42 ` [PATCH v2 1/6] mfd: Add ChromeOS EC messages header Simon Glass
2013-02-13 2:42 ` [PATCH v2 2/6] mfd: Add ChromeOS EC implementation Simon Glass
2013-02-13 3:35 ` Joe Perches [this message]
2013-02-16 3:58 ` Simon Glass
2013-02-13 2:42 ` [PATCH v2 3/6] mfd: Add ChromeOS EC I2C driver Simon Glass
2013-02-13 2:42 ` [PATCH v2 4/6] mfd: Add ChromeOS EC SPI driver Simon Glass
2013-02-13 2:42 ` [PATCH v2 5/6] Input: matrix-keymap: Add function to read the new DT binding Simon Glass
2013-02-13 5:32 ` a0131647
2013-02-13 19:43 ` Dmitry Torokhov
2013-02-14 5:40 ` Simon Glass
2013-02-13 2:42 ` [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver Simon Glass
2013-02-13 20:02 ` Dmitry Torokhov
2013-02-14 6:45 ` Simon Glass
2013-02-14 17:31 ` Dmitry Torokhov
2013-02-16 3:56 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360726546.2220.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=clchiou@chromium.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kliegs@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).