From: li guang <lig.fnst@cn.fujitsu.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: add e820 descriptor attribute field
Date: Fri, 01 Mar 2013 17:12:55 +0800 [thread overview]
Message-ID: <1362129175.2262.86.camel@liguang.fnst.cn.fujitsu.com> (raw)
In-Reply-To: <20d755b3-7796-4f9a-b446-84c6678834f5@email.android.com>
can we fix if it breaks anything?
I think there are sound reasons that
ACPI add these extended attributes.
在 2013-02-28四的 21:28 -0800，H. Peter Anvin写道：
> NAK in the extreme. Not only does this break the bootloader protocol, but there are systems in the field that break if you give e820 anything other than a 20-byte buffer.
>
> liguang <lig.fnst@cn.fujitsu.com> wrote:
>
> >according to ACPI 5.0 Table 15-273
> >Address Range Descriptor Structure,
> >offset 20 is 32-bit field of Extended
> >Attributes for Address Range Descriptor Structure.
> >
> >Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> >---
> > arch/x86/include/uapi/asm/e820.h | 7 ++++++-
> > 1 files changed, 6 insertions(+), 1 deletions(-)
> >
> >diff --git a/arch/x86/include/uapi/asm/e820.h
> >b/arch/x86/include/uapi/asm/e820.h
> >index 2d400b1..eb87284 100644
> >--- a/arch/x86/include/uapi/asm/e820.h
> >+++ b/arch/x86/include/uapi/asm/e820.h
> >@@ -38,6 +38,10 @@
> > #define E820_TYPE_NVS 4
> > #define E820_TYPE_UNUSABLE 5
> >
> >+#define E820_ATTRIB_NV 0x2
> >+#define E820_ATTRIB_SLOW_ACCESS 0x4
> >+#define E820_ATTRIB_ERR_LOG 0x8
> >+
> >
> > /*
> > * reserved RAM used by kernel itself
> >@@ -53,7 +57,8 @@ struct e820entry {
> > __u64 addr; /* start of memory segment */
> > __u64 size; /* size of memory segment */
> > __u32 type; /* type of memory segment */
> >-} __attribute__((packed));
> >+ __u32 attrib;
> >+};
> >
> > struct e820map {
> > __u32 nr_map;
>
next prev parent reply other threads:[~2013-03-01 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 5:27 [PATCH 1/2] x86: change names of e820 memory map type liguang
2013-03-01 5:27 ` [PATCH 2/2] x86: add e820 descriptor attribute field liguang
2013-03-01 5:28 ` H. Peter Anvin
2013-03-01 9:12 ` li guang [this message]
2013-03-01 5:29 ` [PATCH 1/2] x86: change names of e820 memory map type H. Peter Anvin
2013-03-01 9:11 ` li guang
2013-03-01 10:57 ` Ingo Molnar
2013-03-01 15:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362129175.2262.86.camel@liguang.fnst.cn.fujitsu.com \
--to=lig.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).