From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755533Ab3CDHu3 (ORCPT ); Mon, 4 Mar 2013 02:50:29 -0500 Received: from mga14.intel.com ([143.182.124.37]:54389 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755467Ab3CDHu0 (ORCPT ); Mon, 4 Mar 2013 02:50:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,777,1355126400"; d="scan'208";a="263940175" Message-ID: <1362383434.2943.5.camel@sauron> Subject: Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{} From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Huang Shijie Cc: Huang Shijie , dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 04 Mar 2013 09:50:34 +0200 In-Reply-To: <513437DF.2030505@freescale.com> References: <1359349039-11510-1-git-send-email-b32955@freescale.com> <1359349039-11510-2-git-send-email-b32955@freescale.com> <1360684037.12703.117.camel@sauron.fi.intel.com> <1362234094.2745.9.camel@sauron> <513437DF.2030505@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.3 (3.6.3-2.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > The current code uses the @id to store the device id(byte 1). > But if we use the 8 bytes id data as the keyword, and expand the @id > field to 8byte array, > the device id is the second byte now. All the added zeros are for the I do not think you need to store the full array of ID's. Device ID's for all the 4 of above chips are different, which is enough to distinguish between them. The only thing you need to add is the OOB size field to 'struct nand_flash_dev'. -- Best Regards, Artem Bityutskiy