* [patch v1] mfd: da9055 change irq state to default
@ 2013-03-18 9:12 Ashish Jangam
2013-03-27 7:30 ` Ashish Jangam
2013-04-09 8:10 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Ashish Jangam @ 2013-03-18 9:12 UTC (permalink / raw)
To: Mark Brown
Cc: Samuel Ortiz, Axel Lin, Linus Walleij, linux-kernel, David Dajun Chen
This patch changes the irq state from high to the now default low.
Because the default PMIC irq state of DA9055 got changed from high to low.
This change should not affect any of the existing users since all of them
use active low state.
This patch has been tested on smdkv6410.
Signed-off-by: Ashish <ashish.jangam@kpitcummins.com>
---
drivers/mfd/da9055-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index f56a1a9..49cb23d 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
da9055->irq_base = pdata->irq_base;
ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
- IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
da9055->irq_base, &da9055_regmap_irq_chip,
&da9055->irq_data);
if (ret < 0)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch v1] mfd: da9055 change irq state to default
2013-03-18 9:12 [patch v1] mfd: da9055 change irq state to default Ashish Jangam
@ 2013-03-27 7:30 ` Ashish Jangam
2013-04-09 8:10 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Ashish Jangam @ 2013-03-27 7:30 UTC (permalink / raw)
To: Mark Brown
Cc: Samuel Ortiz, Axel Lin, Linus Walleij, linux-kernel, David Dajun Chen
On Mon, 2013-03-18 at 14:42 +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low.
> Because the default PMIC irq state of DA9055 got changed from high to low.
> This change should not affect any of the existing users since all of them
> use active low state.
>
> This patch has been tested on smdkv6410.
>
> Signed-off-by: Ashish <ashish.jangam@kpitcummins.com>
>
> ---
> drivers/mfd/da9055-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index f56a1a9..49cb23d 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
> da9055->irq_base = pdata->irq_base;
>
> ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> da9055->irq_base, &da9055_regmap_irq_chip,
> &da9055->irq_data);
> if (ret < 0)
If there are no comments then can this patch get merged.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch v1] mfd: da9055 change irq state to default
2013-03-18 9:12 [patch v1] mfd: da9055 change irq state to default Ashish Jangam
2013-03-27 7:30 ` Ashish Jangam
@ 2013-04-09 8:10 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-04-09 8:10 UTC (permalink / raw)
To: Ashish Jangam
Cc: Mark Brown, Axel Lin, Linus Walleij, linux-kernel, David Dajun Chen
Hi Ashish,
On Mon, Mar 18, 2013 at 02:42:38PM +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low.
> Because the default PMIC irq state of DA9055 got changed from high to low.
> This change should not affect any of the existing users since all of them
> use active low state.
>
> This patch has been tested on smdkv6410.
>
> Signed-off-by: Ashish <ashish.jangam@kpitcummins.com>
>
> ---
> drivers/mfd/da9055-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-09 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-18 9:12 [patch v1] mfd: da9055 change irq state to default Ashish Jangam
2013-03-27 7:30 ` Ashish Jangam
2013-04-09 8:10 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).