From: James Hogan <james.hogan@imgtec.com>
To: Jeff Dike <jdike@addtoit.com>, Al Viro <viro@ZenIV.linux.org.uk>,
"Richard Weinberger" <richard@nod.at>,
<user-mode-linux-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Cc: James Hogan <james.hogan@imgtec.com>, Nick Piggin <npiggin@kernel.dk>
Subject: [PATCH 1/3] hostfs: remove "will unlock" comment
Date: Wed, 27 Mar 2013 10:47:12 +0000 [thread overview]
Message-ID: <1364381234-22960-2-git-send-email-james.hogan@imgtec.com> (raw)
In-Reply-To: <1364381234-22960-1-git-send-email-james.hogan@imgtec.com>
A "will unlock" comment was added to hostfs in the following commit,
along with a spinlock:
Commit e9193059b1b3733695d5b80e667778311695aa73 ("hostfs: fix races in
dentry_name() and inode_name()").
But the spinlock was subsequently removed in the following commit:
Commit ec2447c278ee973d35f38e53ca16ba7f965ae33d ("hostfs: simplify
locking").
Since the comment is no longer applicable, remove it.
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Nick Piggin <npiggin@kernel.dk>
---
fs/hostfs/hostfs_kern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index 0f6e52d..95b9c87 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -121,7 +121,7 @@ static char *dentry_name(struct dentry *dentry)
if (!name)
return NULL;
- return __dentry_name(dentry, name); /* will unlock */
+ return __dentry_name(dentry, name);
}
static char *inode_name(struct inode *ino)
--
1.8.1.2
next prev parent reply other threads:[~2013-03-27 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 10:47 [PATCH 0/3] hostfs: tweaks from imgdafs review James Hogan
2013-03-27 10:47 ` James Hogan [this message]
2013-03-27 10:47 ` [PATCH 2/3] hostfs: move HOSTFS_SUPER_MAGIC to <linux/magic.h> James Hogan
2013-03-27 10:47 ` [PATCH 3/3] hostfs: use kmalloc instead of kzalloc James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364381234-22960-2-git-send-email-james.hogan@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).