From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963Ab3C0Loi (ORCPT ); Wed, 27 Mar 2013 07:44:38 -0400 Received: from mailout01.c08.mtsvc.net ([205.186.168.189]:54239 "EHLO mailout01.c08.mtsvc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672Ab3C0Log (ORCPT ); Wed, 27 Mar 2013 07:44:36 -0400 From: Peter Hurley To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Min Zhang , Ilya Zykov , Peter Hurley Subject: [PATCH v2 01/18] tty: Don't change receive_room for ioctl(TIOCSETD) Date: Wed, 27 Mar 2013 07:43:51 -0400 Message-Id: <1364384648-6636-2-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1364384648-6636-1-git-send-email-peter@hurleysoftware.com> References: <1363724513-15604-1-git-send-email-peter@hurleysoftware.com> <1364384648-6636-1-git-send-email-peter@hurleysoftware.com> X-Authenticated-User: 125194 peter@hurleysoftware.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tty_set_ldisc() is guaranteed exclusive use of the line discipline by tty_ldisc_lock_pair_timeout(); shutting off input by resetting receive_room is unnecessary. Signed-off-by: Peter Hurley --- drivers/tty/tty_ldisc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index ba49c0e..5a6c43d 100644 --- a/drivers/tty/tty_ldisc.c +++ b/drivers/tty/tty_ldisc.c @@ -537,9 +537,6 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc) return 0; } - /* FIXME: why 'shutoff' input if the ldisc is locked? */ - tty->receive_room = 0; - old_ldisc = tty->ldisc; tty_lock(tty); -- 1.8.1.2