From: Alex Shi <alex.shi@intel.com>
To: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
pjt@google.com, namhyung@kernel.org, efault@gmx.de,
morten.rasmussen@arm.com
Cc: vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, alex.shi@intel.com,
len.brown@intel.com, rafael.j.wysocki@intel.com, jkosina@suse.cz,
clark.williams@gmail.com, tony.luck@intel.com,
keescook@chromium.org, mgorman@suse.de, riel@redhat.com
Subject: [patch v3 6/8] sched: consider runnable load average in move_tasks
Date: Tue, 2 Apr 2013 11:23:26 +0800 [thread overview]
Message-ID: <1364873008-3169-7-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1364873008-3169-1-git-send-email-alex.shi@intel.com>
Except using runnable load average in background, move_tasks is also
the key functions in load balance. We need consider the runnable load
average in it in order to the apple to apple load comparison.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
kernel/sched/fair.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1f9026e..bf4e0d4 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3966,6 +3966,15 @@ static unsigned long task_h_load(struct task_struct *p);
static const unsigned int sched_nr_migrate_break = 32;
+static unsigned long task_h_load_avg(struct task_struct *p)
+{
+ u32 period = p->se.avg.runnable_avg_period;
+ if (!period)
+ return 0;
+
+ return task_h_load(p) * p->se.avg.runnable_avg_sum / period;
+}
+
/*
* move_tasks tries to move up to imbalance weighted load from busiest to
* this_rq, as part of a balancing operation within domain "sd".
@@ -4001,7 +4010,7 @@ static int move_tasks(struct lb_env *env)
if (throttled_lb_pair(task_group(p), env->src_cpu, env->dst_cpu))
goto next;
- load = task_h_load(p);
+ load = task_h_load_avg(p);
if (sched_feat(LB_MIN) && load < 16 && !env->sd->nr_balance_failed)
goto next;
--
1.7.12
next prev parent reply other threads:[~2013-04-02 3:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 3:23 [patch v3 0/8] sched: use runnable avg in load balance Alex Shi
2013-04-02 3:23 ` [patch v3 1/8] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-04-02 3:23 ` [patch v3 2/8] sched: set initial value of runnable avg for new forked task Alex Shi
2013-04-02 3:23 ` [patch v3 3/8] sched: only count runnable avg on cfs_rq's nr_running Alex Shi
2013-04-03 3:19 ` Alex Shi
2013-04-02 3:23 ` [patch v3 4/8] sched: update cpu load after task_tick Alex Shi
2013-04-02 3:23 ` [patch v3 5/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-04-02 3:23 ` Alex Shi [this message]
2013-04-09 7:08 ` [patch v3 6/8] sched: consider runnable load average in move_tasks Vincent Guittot
2013-04-09 8:05 ` Alex Shi
2013-04-09 8:58 ` Vincent Guittot
2013-04-09 10:38 ` Alex Shi
2013-04-09 11:56 ` Vincent Guittot
2013-04-09 14:48 ` Alex Shi
2013-04-09 15:16 ` Vincent Guittot
2013-04-10 2:31 ` Alex Shi
2013-04-10 6:07 ` Michael Wang
2013-04-10 6:55 ` Vincent Guittot
2013-04-02 3:23 ` [patch v3 7/8] sched: consider runnable load average in effective_load Alex Shi
2013-04-02 3:23 ` [patch v3 8/8] sched: use instant load for burst wake up Alex Shi
2013-04-02 7:23 ` [patch v3 0/8] sched: use runnable avg in load balance Michael Wang
2013-04-02 8:34 ` Mike Galbraith
2013-04-02 9:13 ` Michael Wang
2013-04-02 8:35 ` Alex Shi
2013-04-02 9:45 ` Michael Wang
2013-04-03 2:46 ` Michael Wang
2013-04-03 2:56 ` Alex Shi
2013-04-03 3:23 ` Michael Wang
2013-04-03 4:28 ` Alex Shi
2013-04-03 5:38 ` Michael Wang
2013-04-03 5:53 ` Michael Wang
2013-04-03 6:01 ` Alex Shi
2013-04-03 6:22 ` Michael Wang
2013-04-03 6:53 ` Alex Shi
2013-04-03 7:18 ` Michael Wang
2013-04-03 7:28 ` Alex Shi
2013-04-03 8:46 ` Alex Shi
2013-04-03 9:37 ` Michael Wang
2013-04-03 11:17 ` Alex Shi
2013-04-07 3:09 ` Michael Wang
2013-04-07 7:30 ` Alex Shi
2013-04-07 8:56 ` Michael Wang
2013-04-09 5:08 ` Alex Shi
2013-04-10 13:12 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364873008-3169-7-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=clark.williams@gmail.com \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).