linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Chen Gang <gang.chen@asianux.com>
Cc: airlied@linux.ie, bskeggs@redhat.com, airlied@redhat.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
Date: Sun, 07 Apr 2013 13:24:23 +0200	[thread overview]
Message-ID: <1365333863.7207.14.camel@mattotaupa> (raw)
In-Reply-To: <51529E77.2010906@asianux.com>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Dear Chen,


Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang:
>   need remove semicolon, or always return true.

do you know if this cause any problems? Did you find this reading the
code or by using some tools?

> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
> index 7f0e6c3..1ddc03e 100644
> --- a/drivers/gpu/drm/nouveau/nv50_display.c
> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
>  {
>  	struct nv50_display_flip *flip = data;
>  	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
> -					      flip->chan->data);
> +					      flip->chan->data)
>  		return true;
>  	usleep_range(1, 2);
>  	return false;

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2013-04-07 11:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  7:23 [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon Chen Gang
2013-04-03  8:01 ` Chen Gang
2013-04-07  1:03   ` Chen Gang
2013-04-07  3:49     ` Greg KH
2013-04-07  3:57       ` Chen Gang
2013-04-07  4:09         ` Joe Perches
2013-04-07  4:19           ` Chen Gang
2013-04-07 11:24 ` Paul Menzel [this message]
2013-04-07 11:36   ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365333863.7207.14.camel@mattotaupa \
    --to=paulepanter@users.sourceforge.net \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gang.chen@asianux.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).