linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3.8-stable] GFS2: return error if malloc failed in gfs2_rs_alloc()
@ 2013-04-11  2:03 Jonghwan Choi
  2013-04-11  7:59 ` Steven Whitehouse
  0 siblings, 1 reply; 2+ messages in thread
From: Jonghwan Choi @ 2013-04-11  2:03 UTC (permalink / raw)
  To: 'Jonghwan Choi', linux-kernel
  Cc: stable, 'Wei Yongjun', 'Steven Whitehouse'

This patch looks like it should be in the 3.8-stable tree, should we apply
it?

------------------

From: "Wei Yongjun <yongjun_wei@trendmicro.com.cn>"

commit 441362d06be349430d06e37286adce4b90e6ce96 upstream

The error code in gfs2_rs_alloc() is set to ENOMEM when error
but never be used, instead, gfs2_rs_alloc() always return 0.
Fix to return 'error'.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 fs/gfs2/rgrp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index b7eff07..9afba3d6 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
 	RB_CLEAR_NODE(&ip->i_res->rs_node);
 out:
 	up_write(&ip->i_rw_mutex);
-	return 0;
+	return error;
 }
 
 static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3.8-stable] GFS2: return error if malloc failed in gfs2_rs_alloc()
  2013-04-11  2:03 [PATCH 3.8-stable] GFS2: return error if malloc failed in gfs2_rs_alloc() Jonghwan Choi
@ 2013-04-11  7:59 ` Steven Whitehouse
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2013-04-11  7:59 UTC (permalink / raw)
  To: Jonghwan Choi; +Cc: linux-kernel, stable, 'Wei Yongjun'

Hi,

On Thu, 2013-04-11 at 11:03 +0900, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.8-stable tree, should we apply
> it?
> 
Yes, again looks like a good plan,

Steve.

> ------------------
> 
> From: "Wei Yongjun <yongjun_wei@trendmicro.com.cn>"
> 
> commit 441362d06be349430d06e37286adce4b90e6ce96 upstream
> 
> The error code in gfs2_rs_alloc() is set to ENOMEM when error
> but never be used, instead, gfs2_rs_alloc() always return 0.
> Fix to return 'error'.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
>  fs/gfs2/rgrp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index b7eff07..9afba3d6 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
>  	RB_CLEAR_NODE(&ip->i_res->rs_node);
>  out:
>  	up_write(&ip->i_rw_mutex);
> -	return 0;
> +	return error;
>  }
>  
>  static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-11  8:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-11  2:03 [PATCH 3.8-stable] GFS2: return error if malloc failed in gfs2_rs_alloc() Jonghwan Choi
2013-04-11  7:59 ` Steven Whitehouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).