From: Doug Anderson <dianders@chromium.org>
To: Wolfram Sang <wsa@the-dreams.de>, Kukjin Kim <kgene.kim@samsung.com>
Cc: Simon Glass <sjg@chromium.org>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
grant.likely@secretlab.ca, yuvaraj.cd@gmail.com,
ben.dooks@codethink.co.uk, u.kleine-koenig@pengutronix.de,
broonie@opensource.wolfsonmicro.com,
girish.shivananjappa@linaro.org, bhushan.r@samsung.com,
sreekumar.c@samsung.com, prashanth.g@samsung.com, olof@lixom.net,
djkurtz@chromium.org, swarren@wwwdotorg.org, linux@roeck-us.net,
Doug Anderson <dianders@chromium.org>,
Russell King <linux@arm.linux.org.uk>,
Thomas Abraham <thomas.abraham@linaro.org>,
Rahul Sharma <rahul.sharma@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow
Date: Tue, 16 Apr 2013 09:29:01 -0700 [thread overview]
Message-ID: <1366129742-16048-2-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1366129742-16048-1-git-send-email-dianders@chromium.org>
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add future devices (keyboard, sbs, tps65090) we'll add them on top of
this.
The arbitrated bus is numbered 104 simply as a convenience to make it
easier for people poking around to guess that it might have something
to do with the physical bus 4.
The addition is split between the cros5250-common and the snow device
tree file since not all cros5250-class devices use arbitration.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v6: None
Changes in v5:
- Adjust bindings as per Wolfram Sang.
Changes in v4:
- Changed mux gpio syntax to work atop Thomas's "ARM: dts: add pin
state information in client nodes for Exynos5 platforms"; avoid
adding gpios property to i2c@12CA0000 for the same reason.
Changes in v3: None
Changes in v2:
- Use new device tree property names / compatible string.
- Include that the GPIOs for arbitration are active low.
arch/arm/boot/dts/cros5250-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5250-snow.dts | 25 +++++++++++++++++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 8a5b3a6..0a61bbb 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -193,7 +193,8 @@
};
i2c@12CA0000 {
- status = "disabled";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <66000>;
};
i2c@12CB0000 {
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 581ffae..fa85f58 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -16,6 +16,10 @@
model = "Google Snow";
compatible = "google,snow", "samsung,exynos5250";
+ aliases {
+ i2c104 = &i2c_104;
+ };
+
pinctrl@11400000 {
sd3_clk: sd3-clk {
samsung,pin-drv = <0>;
@@ -44,6 +48,27 @@
};
};
+ i2c-arbitrator {
+ compatible = "i2c-arb-gpio-challenge";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c-parent = <&{/i2c@12CA0000}>;
+
+ our-claim-gpio = <&gpf0 3 1>;
+ their-claim-gpios = <&gpe0 4 1>;
+ slew-delay-us = <10>;
+ wait-retry-us = <3000>;
+ wait-free-us = <50000>;
+
+ /* Use ID 104 as a hint that we're on physical bus 4 */
+ i2c_104: i2c@0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
--
1.8.1.3
next prev parent reply other threads:[~2013-04-16 16:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360887677-20758-1-git-send-email-dianders@chromium.org>
2013-02-15 0:21 ` [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-02-15 0:21 ` [PATCH v2 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-02-15 16:39 ` [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren
[not found] ` <CAD=FV=W9WwSsid_KqtDRmAkFXnneRXu5zcakDB3t4hLhOpuCtw@mail.gmail.com>
[not found] ` <511E7295.4000902@wwwdotorg.org>
2013-02-15 17:44 ` Mark Brown
2013-02-15 19:46 ` [PATCH v3 " Doug Anderson
2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-03-05 23:48 ` Naveen Krishna Ch
2013-03-13 7:30 ` Kukjin Kim
2013-03-13 15:14 ` Doug Anderson
2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-03-05 23:49 ` Naveen Krishna Ch
2013-02-15 21:31 ` [PATCH v3 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren
2013-03-11 16:05 ` Doug Anderson
2013-03-13 16:36 ` [PATCH v4 " Doug Anderson
2013-03-13 16:36 ` [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-03-13 16:36 ` [PATCH v4 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-03-13 16:53 ` [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren
2013-03-13 16:59 ` Doug Anderson
2013-03-13 17:29 ` Stephen Warren
[not found] ` <CAD=FV=UW4wGFqsg2B3MmC24jhnba5PSvCh8Wck-V6iuYk+Xifw@mail.gmail.com>
[not found] ` <20130329115821.GC6359@the-dreams.de>
[not found] ` <CAD=FV=XyBZXD1dsOy4kY3CjkFiJXCO+taAJ-zZ8op6V-z9J8jQ@mail.gmail.com>
[not found] ` <20130403191938.GA7875@the-dreams.de>
[not found] ` <CAPnjgZ0bt+ppAMAB1RtoeUKrzUjxxZ3+=GQwHqxByce7fmOLDg@mail.gmail.com>
2013-04-05 20:03 ` Stephen Warren
2013-04-06 18:30 ` Guenter Roeck
2013-04-06 20:11 ` Wolfram Sang
2013-04-07 18:10 ` Guenter Roeck
2013-04-08 9:55 ` Wolfram Sang
2013-04-08 10:26 ` Wolfram Sang
[not found] ` <1365538361-2763-1-git-send-email-dianders@chromium.org>
2013-04-09 20:12 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-04-09 20:12 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-04-09 21:34 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Doug Anderson
2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson
2013-04-10 10:59 ` Kukjin Kim
2013-04-10 11:02 ` Wolfram Sang
2013-04-10 14:12 ` Kukjin Kim
2013-04-09 21:34 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-04-16 9:36 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Wolfram Sang
2013-04-16 9:44 ` Peter Korsgaard
2013-04-16 13:38 ` Guenter Roeck
2013-04-16 15:42 ` Stephen Warren
2013-04-16 16:29 ` [PATCH v6 " Doug Anderson
2013-04-16 16:29 ` Doug Anderson [this message]
2013-04-16 16:35 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Olof Johansson
2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson
2013-04-16 16:36 ` Olof Johansson
2013-04-16 16:34 ` [PATCH v6 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Olof Johansson
2013-04-17 9:34 ` Wolfram Sang
2013-04-16 16:45 ` Guenter Roeck
2013-04-17 9:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366129742-16048-2-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=ben.dooks@codethink.co.uk \
--cc=bhushan.r@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ch.naveen@samsung.com \
--cc=djkurtz@chromium.org \
--cc=girish.shivananjappa@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=prashanth.g@samsung.com \
--cc=rahul.sharma@samsung.com \
--cc=sjg@chromium.org \
--cc=sreekumar.c@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.abraham@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@the-dreams.de \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).