From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933135Ab3ECPO6 (ORCPT ); Fri, 3 May 2013 11:14:58 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:3575 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932459Ab3ECPO5 (ORCPT ); Fri, 3 May 2013 11:14:57 -0400 X-Authority-Analysis: v=2.0 cv=cOZiQyiN c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=O4Sx1LqlDMUA:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=IGil-QtXnCsA:10 a=zxyhxeHiEAsVogvHwHIA:9 a=QEXdDO2ut3YA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1367594095.7373.14.camel@gandalf.local.home> Subject: Re: [PATCH, RFC 14/22] oprofile: always enable IRQ_WORK From: Steven Rostedt To: Robert Richter Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, oprofile-list@lists.sf.net Date: Fri, 03 May 2013 11:14:55 -0400 In-Reply-To: <20130503115332.GT8356@rric.localhost> References: <1367507786-505303-1-git-send-email-arnd@arndb.de> <1367507786-505303-15-git-send-email-arnd@arndb.de> <20130503115332.GT8356@rric.localhost> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote: > On 02.05.13 17:16:18, Arnd Bergmann wrote: > > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > > because of the dependency on the RING_BUFFER code that now uses > > the irq work library. > > > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > > kernel/built-in.o: In function `ring_buffer_write': > > :(.text+0x5bd10): undefined reference to `irq_work_queue' > > Shouldn't this be fixed in the ring_buffer implementation? Does this patch fix it? -- Steve diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 5e9efd4..015f85a 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -71,6 +71,7 @@ config TRACE_CLOCK config RING_BUFFER bool select TRACE_CLOCK + select IRQ_WORK config FTRACE_NMI_ENTER bool @@ -107,7 +108,6 @@ config TRACING select BINARY_PRINTF select EVENT_TRACING select TRACE_CLOCK - select IRQ_WORK config GENERIC_TRACER bool