From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AB5C4167B for ; Mon, 11 Dec 2023 16:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234983AbjLKQlk (ORCPT ); Mon, 11 Dec 2023 11:41:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbjLKQli (ORCPT ); Mon, 11 Dec 2023 11:41:38 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B749A98 for ; Mon, 11 Dec 2023 08:41:44 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD94C433C9; Mon, 11 Dec 2023 16:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702312904; bh=YplM3Lc/uJviJ/vwXKtb5pm7aSZ8QLfQpUexo4dL2iE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ilzGVkJzyKnUP6gPXSvqDBkQBAoL+Io3eCfft5PJ0awXLjCb2xy6GuIudA1K9GNrB 7wKnCVX8v0WTs9Z5ZHYJrJbtJLl/e3oWgoC10v8rkC6ePTUdHII+s+apjgkRPSkJpD eOav2dWutOfiz4a/u3HCfW9Wk8hQh6GGcVNOzn6PryrhpMzgapCucZVXhS+x49k1mN PXFtZObnI46GWdojijwSscsskbLmv97FkYIMMQ7jJc5kWibMWG6EIRJTc5q+RNMMwC WIH4HennPImHllcStg1cr7c6udBqJTeLk7vD1mLabZJy5Z8xsZkAkhDR9RsAA6OkzU 2Fp8UL+NH3yVQ== Date: Mon, 11 Dec 2023 16:41:35 +0000 From: Mark Brown To: David Hildenbrand Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, John Hubbard , Peter Zijlstra Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: <1368c558-c58c-4574-907e-36b07dee31bb@sirena.org.uk> References: <20231206103702.3873743-1-surenb@google.com> <20231206103702.3873743-6-surenb@google.com> <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BnXU97Dc8NyxrdI0" Content-Disposition: inline In-Reply-To: <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> X-Cookie: Better dead than mellow. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BnXU97Dc8NyxrdI0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 11, 2023 at 05:32:16PM +0100, David Hildenbrand wrote: > On 11.12.23 17:15, Suren Baghdasaryan wrote: > > Ok, I was updating my headers and that's why I could not reproduce it. > > David, should the test be modified to handle old linux headers > > (disable the new tests #ifndef _UFFDIO_MOVE or some other way)? > That's an open question: do we want to be able to build selftests against > any host headers, and not the in-tree headers that have to be manually > installed and dirty the git tree? Quite a lot of existing selftests rely on the headers being installed to build... > One obvious drawbacks is that we'll have to deal with all that using a bunch > of #ifdef, and the tests that will be built+run will depend on the host > headers. > Especially the letter is relevant I think: Our upstream testing won't be > able to build+run tests that rely on new upstream features. But that's what > some key benefit of these selftests, and being able to run them > automatically on a bunch of different combinations upstream. ...for exactly this reason. It causes real pain testing new interfaces. > Further, the tests are closely related to the given kernel version, they are > not some completely separate tests. Note that there's a general desire for the tests to *run* with older kernels and use whatever feature test mechanisms exist to skip tests that won't run. That's often needed anyway for configurable things. > (3) avoids dirtying the tree as a "make headers_install" would, but it also > means that each test that makes use of new uapi has to update the relevant > headers (what people working on QEMU are used to). Note that you can do an out of tree build to avoid dirtying things. --BnXU97Dc8NyxrdI0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3O74ACgkQJNaLcl1U h9B0dgf/WZJDnoE/dzWYhyYWKPFZlpPobwsO1rVstQxD6dR5DNJh0GyPL11T0jn6 EJgVd8Esw3KE2twbk7SgsRpf3nz55wD4zyJKiE9po7nyCDwG+xsehhfRtdajnW+p MSubtQFkjCS6tZWnOwAeYlIfXEQ6f8LscjulZxDX4HZxbqYn2KF61jn8BzmUiRQ+ aZFTB3qQ1DLZwOSNMT5WhAedVLN9B7joTDT5rFxftNvOvEWyLk95ugvqsK13GDEe 0u1r4u2jYv4TFr805sq7o1vedsZ50jWRjapAlTu1+8WZcNV15s4Mokb7TELPc4CI KqdTkJiBtDz0xu9dIxjmNccqT3j0YQ== =NqsE -----END PGP SIGNATURE----- --BnXU97Dc8NyxrdI0--