From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Leonardo Bras <leobras.c@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command
Date: Thu, 27 Sep 2018 15:14:03 +0200 [thread overview]
Message-ID: <136913b41707c8556fb5d41969d2080e@sf-tec.de> (raw)
In-Reply-To: <CADvQ+rFPiaGKLyzfSx4DmTnmgG15=Jk0RVy8xuYYyvLPJfDdkA@mail.gmail.com>
Am 2018-09-27 13:23, schrieb Leonardo Bras:
> Hello Rolf,
>
> On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@sf-tec.de>
> wrote:
>> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo
>> Brás:
>>> Creates new Makefile to avoid building driver if
>>> 'make drivers/oprofile/' is called directly.
>>>
>>> This driver is usually built from arch/$ARCH and seems to have
>>> no meaning building alone.
>>>
>>> Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
>>> ---
>>> drivers/oprofile/Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> create mode 100644 drivers/oprofile/Makefile
>>>
>>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>>> new file mode 100644
>>> index 000000000000..acaed2ad6eee
>>> --- /dev/null
>>> +++ b/drivers/oprofile/Makefile
>>> @@ -0,0 +1,2 @@
>>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>>> +
>>
>> Now there is a blank line where it does not need to be.
>>
>> Eike
>
> Oh, it's a Makefile, and as all text files, it have to end with
> newline.
> If I am wrong, please let me know.
No, that's fine. But it means it has to have one LF after "tree.". It
had none, now it hat 2.
Eike
next prev parent reply other threads:[~2018-09-27 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 1:41 [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command Leonardo Brás
2018-09-27 6:34 ` Rolf Eike Beer
2018-09-27 11:23 ` Leonardo Bras
2018-09-27 13:14 ` Rolf Eike Beer [this message]
2018-09-28 1:32 ` Leonardo Brás
2018-09-28 1:55 ` Leonardo Brás
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=136913b41707c8556fb5d41969d2080e@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).