From: Steven Rostedt <rostedt@goodmis.org>
To: Jovi Zhang <bookjovi@gmail.com>
Cc: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
masami.hiramatsu.pt@hitachi.com,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 03/11] tracing: add soft disable for syscall events
Date: Sat, 22 Jun 2013 07:45:23 -0400 [thread overview]
Message-ID: <1371901523.18733.139.camel@gandalf.local.home> (raw)
In-Reply-To: <CACV3sbJcgQbLdjypvRPL3cU+cki5bzinpnyy2ESmS5mLPvPVHA@mail.gmail.com>
On Sat, 2013-06-22 at 13:08 +0800, Jovi Zhang wrote:
> > I would really like to make these smaller. They are made for every
> > system call, and I consider tracing to always be added overhead. I hate
> > it when we waste more memory for tracing as very few people use it
> > (compared to those that use Linux).
> >
> > Is it possible to allocate this only when its first used?
> >
> > -- Steve
>
> I think the answer is yes.
>
> Compare with link ftrace_event_file with static syscall_metadata, another option
> is put into structure trace_array, just like enabled_enter_syscalls and
> enabled_exit_syscalls BITMAP already in there
> (need change to dynamic allocated NR_syscalls array, just keep a
> pointer in trace_array).
>
> Then in this way, there don't have any extra size overhead for static
> syscall_metadata,
> but need to allocate a array with NR_syscalls elements when first use
> syscall tracing.
>
> which option do you prefer? steven.
Hey, if it only allocates when tracing is used, that's a big plus.
Tracing should be treated as a drug. Just like not allowing smoking in
public places, only punish the users, not those that want to breath
fresh air.
-- Steve
next prev parent reply other threads:[~2013-06-22 11:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 18:31 [PATCH 00/11] tracing: trace event triggers Tom Zanussi
2013-06-20 18:31 ` [PATCH 01/11] tracing: simplify event_enable_read() Tom Zanussi
2013-06-21 6:52 ` Masami Hiramatsu
2013-06-20 18:31 ` [PATCH 02/11] tracing: add missing syscall_metadata comment Tom Zanussi
2013-06-21 7:06 ` Masami Hiramatsu
2013-06-21 19:48 ` Steven Rostedt
2013-06-20 18:31 ` [PATCH 03/11] tracing: add soft disable for syscall events Tom Zanussi
2013-06-21 6:53 ` zhangwei(Jovi)
2013-06-21 20:22 ` Steven Rostedt
2013-06-22 5:08 ` Jovi Zhang
2013-06-22 11:45 ` Steven Rostedt [this message]
2013-06-20 18:31 ` [PATCH 04/11] tracing: fix disabling of soft disable Tom Zanussi
2013-06-21 11:12 ` Masami Hiramatsu
2013-06-21 20:39 ` Steven Rostedt
2013-06-21 21:14 ` Tom Zanussi
2013-06-22 5:25 ` Tom Zanussi
2013-07-01 11:38 ` Masami Hiramatsu
2013-06-20 18:31 ` [PATCH 05/11] tracing: add basic event trigger framework Tom Zanussi
2013-06-21 12:12 ` Masami Hiramatsu
2013-06-20 18:31 ` [PATCH 06/11] tracing: add 'traceon' and 'traceoff' event trigger commands Tom Zanussi
2013-06-20 18:31 ` [PATCH 07/11] tracing: add 'snapshot' event trigger command Tom Zanussi
2013-06-20 18:31 ` [PATCH 08/11] tracing: add 'stacktrace' " Tom Zanussi
2013-06-20 18:31 ` [PATCH 09/11] tracing: add 'enable_event' and 'disable_event' event trigger commands Tom Zanussi
2013-06-20 18:31 ` [PATCH 10/11] tracing: add and use generic set_trigger_filter() implementation Tom Zanussi
2013-06-21 4:18 ` Masami Hiramatsu
2013-06-21 17:59 ` Tom Zanussi
2013-06-22 11:53 ` Steven Rostedt
2013-06-20 18:31 ` [PATCH 11/11] tracing: add documentation for trace event triggers Tom Zanussi
2013-06-21 19:45 ` [PATCH 00/11] tracing: " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371901523.18733.139.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bookjovi@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=oleg@redhat.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).