From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060Ab3FYG7s (ORCPT ); Tue, 25 Jun 2013 02:59:48 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:42515 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751256Ab3FYG7q (ORCPT ); Tue, 25 Jun 2013 02:59:46 -0400 Message-ID: <1372143585.1245.44.camel@joe-AO722> Subject: Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq files From: Joe Perches To: Viresh Kumar Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org Date: Mon, 24 Jun 2013 23:59:45 -0700 In-Reply-To: References: <1372102237-8757-1-git-send-email-paul.gortmaker@windriver.com> <1372102237-8757-26-git-send-email-paul.gortmaker@windriver.com> <1372133724.1245.38.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-06-25 at 12:14 +0530, Viresh Kumar wrote: > On 25 June 2013 09:45, Joe Perches wrote: > > Viresh, there's no absolute "right" way to do this. > > Yeah Joe, but I thought its better to keep it consistent within a file. > So, while writing new files, keep what you want but for existing ones > follow what's in there. Sure Viresh. I could agree with that, but that's not what you recommended though. "Check this everywhere" isn't the same as the advice you just gave above. There are those that think it's better to convert each instance whenever touched to what they think of as "kernel" style. Me, I'd just as soon convert to aligned indentation and generic kernel style whenever touching any code, even if it differs from the existing file style. cheers, Joe