From: Joseph Lo <josephl@nvidia.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Will Deacon <will.deacon@arm.com>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 07/32] arm: delete __cpuinit/__CPUINIT usage from all ARM users
Date: Tue, 2 Jul 2013 16:52:00 +0800 [thread overview]
Message-ID: <1372755120.2874.18.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <1372102237-8757-8-git-send-email-paul.gortmaker@windriver.com>
Adding linux-tegra in Cc.
On Tue, 2013-06-25 at 03:30 +0800, Paul Gortmaker wrote:
> The __cpuinit type of throwaway sections might have made sense
> some time ago when RAM was more constrained, but now the savings
> do not offset the cost and complications. For example, the fix in
> commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
> is a good example of the nasty type of bugs that can be created
> with improper use of the various __init prefixes.
>
> After a discussion on LKML[1] it was decided that cpuinit should go
> the way of devinit and be phased out. Once all the users are gone,
> we can then finally remove the macros themselves from linux/init.h.
>
> Note that some harmless section mismatch warnings may result, since
> notify_cpu_starting() and cpu_up() are arch independent (kernel/cpu.c)
> and are flagged as __cpuinit -- so if we remove the __cpuinit from
> the arch specific callers, we will also get section mismatch warnings.
> As an intermediate step, we intend to turn the linux/init.h cpuinit
> related content into no-ops as early as possible, since that will get
> rid of these warnings. In any case, they are temporary and harmless.
>
> This removes all the ARM uses of the __cpuinit macros from C code,
> and all __CPUINIT from assembly code. It also had two ".previous"
> section statements that were paired off against __CPUINIT
> (aka .section ".cpuinit.text") that also get removed here.
>
> [1] https://lkml.org/lkml/2013/5/20/589
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [This commit is part of the __cpuinit removal work. If you don't see
> any problems with it, then you don't have to do anything ; it will be
> submitted with all the rest of the __cpuinit removal work. On the
> other hand, if you want to carry this patch in with your other pending
> changes so as to handle conflicts with other pending work yourself, then
> that is fine too, as the commits can largely be treated independently.
> For more information, please see: https://lkml.org/lkml/2013/6/20/513 ]
>
Hi Paul,
I just tested this series on Tegra platform. It looks broken CPU hotplug
function for Tegra at least. The CPU can't plug-in after unplugging. And
the system resume function also not working when "enable_nonboot_cpus".
Both of the issue cause system hang up. Are we missing something for
__cpuinit removal work?
Thanks,
Joseph
next prev parent reply other threads:[~2013-07-02 8:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372102237-8757-1-git-send-email-paul.gortmaker@windriver.com>
2013-06-24 19:30 ` [PATCH 01/32] init.h: remove __cpuinit sections from the kernel Paul Gortmaker
2013-06-24 19:51 ` Joe Perches
2013-06-24 22:10 ` Joe Perches
2013-06-24 19:30 ` [PATCH 02/32] modpost: remove all traces of cpuinit/cpuexit sections Paul Gortmaker
2013-06-24 19:30 ` [PATCH 03/32] alpha: delete __cpuinit usage from all users Paul Gortmaker
2013-06-24 19:30 ` [PATCH 04/32] powerpc: " Paul Gortmaker
2013-06-24 19:30 ` [PATCH 05/32] parisc: " Paul Gortmaker
2013-06-24 19:30 ` [PATCH 06/32] ia64: delete __cpuinit usage from all ia64 users Paul Gortmaker
2013-06-24 19:30 ` [PATCH 07/32] arm: delete __cpuinit/__CPUINIT usage from all ARM users Paul Gortmaker
2013-07-02 8:52 ` Joseph Lo [this message]
2013-07-02 8:58 ` Russell King - ARM Linux
2013-07-02 17:53 ` Paul Gortmaker
2013-06-24 19:30 ` [PATCH 08/32] sparc: delete __cpuinit/__CPUINIT usage from all users Paul Gortmaker
2013-06-24 19:30 ` [PATCH 09/32] arm64: delete __cpuinit " Paul Gortmaker
2013-06-25 8:45 ` Catalin Marinas
2013-06-24 19:30 ` [PATCH 10/32] arc: delete __cpuinit usage from all arc files Paul Gortmaker
2013-06-25 4:37 ` Vineet Gupta
2013-06-24 19:30 ` [PATCH 11/32] blackfin: delete __cpuinit usage from all blackfin files Paul Gortmaker
2013-06-24 22:40 ` Mike Frysinger
2013-06-24 19:30 ` [PATCH 12/32] s390: delete __cpuinit usage from all s390 files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 13/32] sh: delete __cpuinit usage from all sh files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 14/32] tile: delete __cpuinit usage from all tile files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 15/32] metag: delete __cpuinit usage from all metag files Paul Gortmaker
2013-06-25 15:10 ` James Hogan
2013-06-24 19:30 ` [PATCH 16/32] cris: delete __cpuinit usage from all cris files Paul Gortmaker
2013-06-25 10:42 ` Jesper Nilsson
2013-06-24 19:30 ` [PATCH 17/32] frv: delete __cpuinit usage from all frv files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 18/32] hexagon: delete __cpuinit usage from all hexagon files Paul Gortmaker
2013-07-08 17:01 ` Richard Kuo
2013-06-24 19:30 ` [PATCH 19/32] m32r: delete __cpuinit usage from all m32r files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 20/32] openrisc: delete __cpuinit usage from all openrisc files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 21/32] xtensa: delete __cpuinit usage from all xtensa files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 22/32] score: delete __cpuinit usage from all score files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 23/32] x86: delete __cpuinit usage from all x86 files Paul Gortmaker
2013-06-24 19:37 ` Ingo Molnar
2013-06-24 19:57 ` Thomas Gleixner
2013-06-24 23:12 ` H. Peter Anvin
2013-06-25 2:16 ` Paul Gortmaker
2013-06-24 19:30 ` [PATCH 24/32] clocksource+irqchip: delete __cpuinit usage from all related files Paul Gortmaker
2013-06-24 19:56 ` Thomas Gleixner
2013-06-24 19:30 ` [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq files Paul Gortmaker
2013-06-24 22:42 ` Dirk Brandewie
2013-06-25 3:31 ` Viresh Kumar
2013-06-25 4:15 ` Joe Perches
2013-06-25 6:44 ` Viresh Kumar
2013-06-25 6:59 ` Joe Perches
2013-06-25 7:01 ` Viresh Kumar
2013-06-25 14:30 ` Paul Gortmaker
2013-06-24 19:30 ` [PATCH 26/32] hwmon: delete __cpuinit usage from all hwmon files Paul Gortmaker
2013-06-24 20:11 ` [lm-sensors] " Guenter Roeck
2013-06-24 19:30 ` [PATCH 27/32] acpi: delete __cpuinit usage from all acpi files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 28/32] net: delete __cpuinit usage from all net files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 29/32] rcu: delete __cpuinit usage from all rcu files Paul Gortmaker
2013-06-25 1:10 ` Josh Triplett
2013-06-25 19:32 ` Paul E. McKenney
2013-06-24 19:30 ` [PATCH 30/32] kernel: delete __cpuinit usage from all core kernel files Paul Gortmaker
2013-06-24 19:30 ` [PATCH 31/32] drivers: delete __cpuinit usage from all remaining drivers files Paul Gortmaker
2013-06-24 20:33 ` Greg Kroah-Hartman
2013-06-24 19:30 ` [PATCH 32/32] block: delete __cpuinit usage from all block files Paul Gortmaker
2013-06-24 20:00 ` [PATCH-next 00/32] Delete support for __cpuinit Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372755120.2874.18.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul.gortmaker@windriver.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).