From: Nestor Lopez Casado <nlopezcasad@logitech.com>
To: jkosina@suse.cz
Cc: benjamin.tissoires@gmail.com, adlr@chromium.org,
joseph.salisbury@canonical.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set
Date: Thu, 18 Jul 2013 06:21:31 -0700 [thread overview]
Message-ID: <1374153691-25100-2-git-send-email-nlopezcasad@logitech.com> (raw)
In-Reply-To: <1374153691-25100-1-git-send-email-nlopezcasad@logitech.com>
Set querying_devices flag to true when we start the enumeration
process.
This was missing from the original patch. It never produced
undesirable effects as it is highly improbable to have a second
enumeration triggered while a first one was still in progress.
Signed-off-by: Nestor Lopez Casado <nlopezcasad@logitech.com>
---
drivers/hid/hid-logitech-dj.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 0d13389..d4657a5 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -488,6 +488,8 @@ static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
if (djrcv_dev->querying_devices)
return 0;
+ djrcv_dev->querying_devices = true;
+
dj_report = kzalloc(sizeof(struct dj_report), GFP_KERNEL);
if (!dj_report)
return -ENOMEM;
--
1.7.9.5
next prev parent reply other threads:[~2013-07-18 13:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 13:21 [PATCH 1/2] Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue"" Nestor Lopez Casado
2013-07-18 13:21 ` Nestor Lopez Casado [this message]
2013-08-01 10:09 ` [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set Benjamin Tissoires
2013-08-02 1:11 ` Jiri Kosina
2013-08-02 18:31 ` Benjamin Tissoires
2013-08-05 13:22 ` Jiri Kosina
2013-08-05 14:40 ` Benjamin Tissoires
2013-08-06 21:03 ` Sune Mølgaard
2013-08-09 9:36 ` Jiri Kosina
2013-08-10 17:21 ` Jiri Kosina
2013-07-18 20:28 ` [PATCH 1/2] Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue"" Peter Hurley
2013-07-18 22:09 ` Sarah Sharp
2013-07-18 23:37 ` Peter Hurley
2013-07-19 8:35 ` Benjamin Tissoires
2013-07-19 14:38 ` Joseph Salisbury
2013-07-19 21:31 ` Peter Hurley
2013-07-22 11:44 ` Jiri Kosina
2013-07-22 14:03 ` Peter Hurley
2013-07-22 15:27 ` Alan Stern
2013-07-19 15:14 ` Alan Stern
2013-07-19 16:43 ` Nestor Lopez Casado
2013-08-12 21:54 ` Peter Wu
2013-08-13 12:13 ` Peter Hurley
2013-08-13 15:42 ` Peter Wu
2013-08-13 16:34 ` Peter Hurley
2013-07-22 14:35 ` Jiri Kosina
2013-07-22 19:21 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374153691-25100-2-git-send-email-nlopezcasad@logitech.com \
--to=nlopezcasad@logitech.com \
--cc=adlr@chromium.org \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=joseph.salisbury@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).