From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5412CC04ABB for ; Thu, 13 Sep 2018 09:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBCE720866 for ; Thu, 13 Sep 2018 09:12:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCE720866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbeIMOUv (ORCPT ); Thu, 13 Sep 2018 10:20:51 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44320 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726862AbeIMOUv (ORCPT ); Thu, 13 Sep 2018 10:20:51 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8D946xg075878 for ; Thu, 13 Sep 2018 05:12:16 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mfh5x0wfx-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Sep 2018 05:12:16 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Sep 2018 10:12:14 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 13 Sep 2018 10:12:11 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8D9CARG57999564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Sep 2018 09:12:10 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65C7F52059; Thu, 13 Sep 2018 12:11:58 +0100 (BST) Received: from oc0155643701.ibm.com (unknown [9.152.224.42]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id CBB6A5204F; Thu, 13 Sep 2018 12:11:57 +0100 (BST) Subject: Re: [PATCH v9 13/22] s390: vfio-ap: sysfs interface to view matrix mdev matrix To: Tony Krowiak , Cornelia Huck , Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com References: <1534196899-16987-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1534196899-16987-14-git-send-email-akrowiak@linux.vnet.ibm.com> <20180820160802.1fe8f704.cohuck@redhat.com> <0e8bac2b-31a0-a1de-c6cf-e824cd256af6@linux.ibm.com> From: Halil Pasic Date: Thu, 13 Sep 2018 11:12:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0e8bac2b-31a0-a1de-c6cf-e824cd256af6@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18091309-0016-0000-0000-00000204CFDD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18091309-0017-0000-0000-0000325B9E76 Message-Id: <1375257e-38c3-f9e3-049e-d1a602d084c9@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-13_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809130096 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2018 07:01 PM, Tony Krowiak wrote: > On 08/20/2018 10:08 AM, Cornelia Huck wrote: >> I find this output to be a bit confusing; but OTOH, I'm probably not >> the person to parse it :) Still, some comments. >> >>  From previous discussions, ISTR that this is mainly supposed to be a >> debugging/administration aid. Of course, this generates some questions: >> - Should this be in sysfs (sysfs attributes are supposed to follow the >>    "one value per file" rule, at least for the most part), or would >>    debugfs be a better fit? >> - Should userspace code be able to introspect the current >>    configuration? If yes, it might be better to have some >>    not-so-nice-but-easily-parsable output, possibly one attribute for >>    the assigned adapters and one for the assigned domains, and a tool >>    which distills that into a nice "matrix" with labeled rows and >>    columns for human consumption. >> >> That said, I don't really have major objections to that interface. > > For now, I will leave it in, but we could conceivably simplify configuration > of the matrix and adhere to sysfs rules by modeling this after the AP bus > apmask and aqmask sysfs interfaces. If we did that, there would need to be only > three RW sysfs interfaces: > > apm or apmask or ap_mask or adapter_mask or apid_mask > aqm or aqmask or aq_mask or domains or usage_domain_mask or apqi_mask > adm or admask or ad_mask or control_domains or control_domain_mask or domain_mask > > To assign a device, either a bitmask or a comma separated list of IDs prepended > with a '+' could be passed in. To unassign a device, either a bitmask in or a > comma-separated list of IDs prepended with a '-' could be passed in. > > Reading an attribute would return the mask. As you suggested, tools could be > provided to parse the output and display it in a human-readable format. > I would prefer an interface where one can set at least one whole mask in one go over the current one that let us manipulate just one bit at a time. Hallil >> >>> Signed-off-by: Tony Krowiak >>> Reviewed-by: Halil Pasic >>> Tested-by: Michael Mueller >>> Tested-by: Farhan Ali >>> Tested-by: Pierre Morel >>> Signed-off-by: Christian Borntraeger >>> --- >>>   drivers/s390/crypto/vfio_ap_ops.c |   52 +++++++++++++++++++++++++++++++++++++ >>>   1 files changed, 52 insertions(+), 0 deletions(-) > >