From: Pawel Moll <pawel.moll@arm.com>
To: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init_time hook
Date: Fri, 30 Aug 2013 14:12:10 +0100 [thread overview]
Message-ID: <1377868330.3342.10.camel@hornet> (raw)
In-Reply-To: <1377856951.3655.34.camel@linaro1.home>
On Fri, 2013-08-30 at 11:02 +0100, Jon Medhurst (Tixy) wrote:
> On Thu, 2013-08-29 at 20:16 +0200, Sebastian Hesselbarth wrote:
> > On 08/29/13 15:35, Arnd Bergmann wrote:
> > > On Tuesday 27 August 2013, Sebastian Hesselbarth wrote:
> > >> @@ -422,16 +419,8 @@ void __init v2m_dt_init_early(void)
> > >> pr_warning("vexpress: DT HBI (%x) is not matching "
> > >> "hardware (%x)!\n", dt_hbi, hbi);
> > >> }
> > >> -}
> > >> -
> > >> -static void __init v2m_dt_timer_init(void)
> > >> -{
> > >> - of_clk_init(NULL);
> > >>
> > >> - clocksource_of_init();
> > >> -
> > >> - versatile_sched_clock_init(vexpress_get_24mhz_clock_base(),
> > >> - 24000000);
> > >> + versatile_sched_clock_init(vexpress_get_24mhz_clock_base(), 24000000);
> > >> }
> > >
> > > You are moving versatile_sched_clock_init() ahead of clocksource_of_init(), which I suspect
> > > won't work. Have you checked this?
> >
> > "Checked" as in "Tested", no I haven't.
> >
> > But non-DT v2m has it in v2m_init_early also, while v2m_sp804_init()
> > is called in v2m_timer_init().
> >
> > That matches the above approach taken for DT v2m where
> > versatile_sched_clock_init() is now called from v2m_dt_init_early()
> > and clocksource_of_init() called from arch-wide .timer_init.
> >
> > get_maintainer.pl did not spit out any additional maintainer except
> > Russell of course. You know someone who can test the above?
>
> After adding of_clk_init(NULL) to time_init() things boot OK for me with
> this patch. However, do we know that sched_clock is never going to get
> read before time_init() has actually started the clock it reads? Are we
> making things more fragile?
The versatile_sched_clock_init() is currently completely independent of
the clocksource infrastructure, so no harm should be done at all by
moving it.
Paweł
next prev parent reply other threads:[~2013-08-30 13:12 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:04 [RFC 00/17] ARM: provide common arch init for DT clocks Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 01/17] clk: ensure __clk_of_table is only initialized once Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 02/17] ARM: call clk_of_init from time_init Sebastian Hesselbarth
2013-08-20 15:46 ` Stephen Warren
2013-08-20 19:47 ` Sebastian Hesselbarth
2013-08-20 19:52 ` Stephen Warren
2013-08-20 20:19 ` Sebastian Hesselbarth
2013-08-21 18:54 ` Arnd Bergmann
2013-08-22 7:25 ` Mike Turquette
2013-08-22 17:28 ` Arnd Bergmann
2013-08-20 20:44 ` Arnd Bergmann
2013-08-20 20:57 ` Stephen Warren
2013-08-21 18:51 ` Arnd Bergmann
2013-08-20 2:04 ` [RFC 03/17] ARM: dove: remove custom .init_time hook Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 04/17] ARM: exynos: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 05/17] ARM: highbank: " Sebastian Hesselbarth
2013-08-20 19:12 ` Rob Herring
2013-08-20 20:01 ` Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 06/17] ARM: imx: " Sebastian Hesselbarth
2013-08-20 7:26 ` Sascha Hauer
2013-08-20 8:48 ` Sebastian Hesselbarth
2013-08-20 9:10 ` Sascha Hauer
2013-08-20 9:20 ` Sebastian Hesselbarth
2013-08-20 10:20 ` Russell King - ARM Linux
2013-08-20 10:37 ` Sebastian Hesselbarth
2013-08-20 10:42 ` Russell King - ARM Linux
2013-08-20 10:46 ` Sebastian Hesselbarth
2013-08-20 9:23 ` [RFC v2] " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 07/17] ARM: kirkwood: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 08/17] ARM: mvebu: " Sebastian Hesselbarth
2013-08-20 12:50 ` Ezequiel Garcia
2013-08-20 13:12 ` Sebastian Hesselbarth
2013-08-20 14:01 ` Ezequiel Garcia
2013-08-23 10:06 ` Gregory CLEMENT
2013-08-23 10:32 ` Sebastian Hesselbarth
2013-08-23 11:39 ` Gregory CLEMENT
2013-08-23 12:13 ` Sebastian Hesselbarth
2013-08-23 14:23 ` Gregory CLEMENT
2013-08-23 14:34 ` Gregory CLEMENT
2013-08-20 2:04 ` [RFC 09/17] ARM: mxs: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 10/17] ARM: nspire: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 11/17] ARM: rockchip: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 12/17] ARM: socfpga: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 13/17] ARM: sti: " Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 14/17] ARM: tegra: remove .init_time hook to clocksource_of_init Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 15/17] ARM: vexpress: remove custom .init_time hook Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 16/17] clk: vt8500: remove call to of_clk_init Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 17/17] clk: zynq: " Sebastian Hesselbarth
2013-08-23 0:26 ` Sören Brinkmann
2013-08-23 0:59 ` Sören Brinkmann
2013-08-23 7:32 ` Steffen Trumtrar
2013-08-23 16:00 ` Sören Brinkmann
2013-08-23 23:38 ` Steffen Trumtrar
2013-08-26 11:15 ` Michal Simek
2013-08-26 12:07 ` Steffen Trumtrar
2013-08-26 12:53 ` Sebastian Hesselbarth
2013-08-26 15:14 ` Michal Simek
2013-08-26 15:31 ` Steffen Trumtrar
2013-08-26 15:16 ` Sören Brinkmann
2013-08-26 15:33 ` Steffen Trumtrar
2013-08-23 9:30 ` Sebastian Hesselbarth
2013-08-23 17:19 ` Sören Brinkmann
2013-08-23 17:44 ` Sebastian Hesselbarth
2013-08-23 23:22 ` Steffen Trumtrar
2013-08-26 15:20 ` Sören Brinkmann
2013-08-27 21:27 ` [PATCH RFC v2 00/16] ARM: provide common arch init for DT clocks Sebastian Hesselbarth
2013-08-27 21:27 ` [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init Sebastian Hesselbarth
2013-08-27 22:19 ` Sören Brinkmann
2013-08-27 22:58 ` Sebastian Hesselbarth
2013-08-27 23:20 ` Sören Brinkmann
2013-08-29 13:45 ` Arnd Bergmann
2013-09-04 19:32 ` Sebastian Hesselbarth
2013-09-04 20:41 ` Sören Brinkmann
2013-09-04 20:52 ` Sebastian Hesselbarth
2013-09-04 20:59 ` Sören Brinkmann
2013-09-05 9:34 ` Arnd Bergmann
2013-08-27 21:27 ` [PATCH RFC v2 02/16] ARM: dove: remove custom .init_time hook Sebastian Hesselbarth
2013-08-27 21:27 ` [PATCH RFC v2 03/16] ARM: exynos: " Sebastian Hesselbarth
2013-08-27 21:27 ` [PATCH RFC v2 04/16] ARM: highbank: " Sebastian Hesselbarth
2013-08-27 23:13 ` Mike Turquette
2013-08-27 21:27 ` [PATCH RFC v2 05/16] ARM: imx: " Sebastian Hesselbarth
2013-08-29 11:00 ` Shawn Guo
2013-08-27 21:28 ` [PATCH RFC v2 06/16] ARM: kirkwood: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 07/16] ARM: mvebu: " Sebastian Hesselbarth
2013-08-28 6:28 ` Gregory CLEMENT
2013-08-27 21:28 ` [PATCH RFC v2 08/16] ARM: mxs: " Sebastian Hesselbarth
2013-08-27 23:16 ` Mike Turquette
2013-08-29 11:08 ` Shawn Guo
2013-08-29 11:32 ` Sebastian Hesselbarth
2013-08-29 12:58 ` Shawn Guo
2013-08-27 21:28 ` [PATCH RFC v2 09/16] ARM: nspire: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 10/16] ARM: rockchip: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 11/16] ARM: socfpga: remove call to of_clk_init Sebastian Hesselbarth
2013-08-29 15:38 ` Dinh Nguyen
2013-08-29 17:23 ` Arnd Bergmann
2013-08-27 21:28 ` [PATCH RFC v2 12/16] ARM: sti: remove custom .init_time hook Sebastian Hesselbarth
2013-08-29 16:29 ` [STLinux Kernel] " Srinivas KANDAGATLA
2013-08-27 21:28 ` [PATCH RFC v2 13/16] ARM: tegra: split tegra_pmc_init() in two Sebastian Hesselbarth
2013-08-27 21:59 ` Stephen Warren
2013-08-27 22:09 ` Sebastian Hesselbarth
2013-09-11 19:56 ` Stephen Warren
2013-09-12 6:21 ` Sebastian Hesselbarth
2013-09-12 16:32 ` Stephen Warren
2013-08-27 21:28 ` [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init_time hook Sebastian Hesselbarth
2013-08-29 13:35 ` Arnd Bergmann
2013-08-29 18:16 ` Sebastian Hesselbarth
2013-08-30 10:02 ` Jon Medhurst (Tixy)
2013-08-30 11:39 ` Russell King - ARM Linux
2013-08-30 13:12 ` Pawel Moll [this message]
2013-08-27 21:28 ` [PATCH RFC v2 15/16] clk: vt8500: remove call to of_clk_init Sebastian Hesselbarth
2013-08-27 23:16 ` Mike Turquette
2013-08-29 13:42 ` Arnd Bergmann
2013-08-27 21:28 ` [PATCH RFC v2 16/16] ARM: zynq: Don't call of_clk_init() Sebastian Hesselbarth
2013-08-29 13:37 ` Arnd Bergmann
2013-08-29 14:21 ` Michal Simek
2013-08-29 17:20 ` Arnd Bergmann
2013-08-29 18:14 ` Michal Simek
2013-08-29 18:20 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377868330.3342.10.camel@hornet \
--to=pawel.moll@arm.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).