From: Joe Perches <joe@perches.com>
To: "Du, Changbin" <changbin.du@gmail.com>
Cc: jbaron@akamai.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dynamic_debug: add wildcard support to filter files/functions/modules
Date: Tue, 29 Oct 2013 09:20:23 -0700 [thread overview]
Message-ID: <1383063623.2713.12.camel@joe-AO722> (raw)
In-Reply-To: <1383053609-2895-1-git-send-email-changbin.du@gmail.com>
On Tue, 2013-10-29 at 21:33 +0800, Du, Changbin wrote:
> This patch add wildcard '*'(matches zero or more characters) and '?'
> (matches one character) support when qurying debug flags.
Hi again. Some trivial notes and a possible logic error:
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -127,6 +127,43 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg)
> query->first_lineno, query->last_lineno);
> }
>
> +/* check if the string matches given pattern which includes wildcards */
> +static bool match_pattern(const char *pattern, const char *string)
> +{
> + const char *s = string,
> + *p = pattern;
This sort of alignment is pretty unusual.
Most kernel uses just repeat the type like:
const char *s = string;
const char *p = pattern;
> + bool star = 0;
bool star = false;
> +
> + while (*s) {
> + switch (*p) {
> + case '?':
> + ++s, ++p;
> + break;
> + case '*':
> + star = true;
> + string = s;
> + if (!*++p)
> + return true;
> + pattern = p;;
repeated ;
Running your patches through checkpatch should find
this sort of defect.
> + break;
> + default:
> + if (*s != *p) {
> + if (!star)
> + return false;
> + string++;
> + s = string;
> + p = pattern;
> + break;
> + }
> + ++s, ++p;
Maybe nicer with an if/else, I think you're still
missing a reset of "star = false;" and I also think
it's better to use a break here too.
if (*s == *p) {
s++;
p++;
star = false;
} else {
if (!star)
return false;
string++;
s = string;
p = pattern;
}
break;
next prev parent reply other threads:[~2013-10-29 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:02 [PATCH] dynamic_debug: add wildcard support to filter files/functions/modules Du, Changbin
2013-07-25 16:47 ` Joe Perches
2013-07-30 3:59 ` Jason Baron
2013-10-28 15:29 ` [PATCH v2] " Du, Changbin
2013-10-28 16:30 ` Joe Perches
2013-10-29 8:04 ` Changbin Du
2013-10-29 13:33 ` [PATCH v3] " Du, Changbin
2013-10-29 16:20 ` Joe Perches [this message]
2013-10-30 6:58 ` Changbin Du
2013-10-30 13:57 ` Changbin Du
2013-10-30 14:21 ` [PATCH v4 1/2] " Du, Changbin
2013-10-30 14:21 ` [PATCH v4 2/2] dynamic-debug-howto.txt: update since new wildcard support Du, Changbin
2013-10-29 20:21 ` [PATCH v3] dynamic_debug: add wildcard support to filter files/functions/modules Marcel Holtmann
2013-10-30 6:24 ` Changbin Du
2013-10-31 22:52 ` [PATCH v2] " Andrew Morton
2013-10-31 23:30 ` Joe Perches
2013-11-07 3:04 ` Changbin Du
2013-11-07 3:11 ` Changbin Du
2013-11-07 6:12 ` Joe Perches
2013-11-15 4:01 ` Changbin Du
2013-11-16 8:24 ` [PATCH v5 0/3] add wildcard support for dynamic debug Du, Changbin
2013-11-16 8:24 ` [PATCH v5 1/3] lib/parser.c: add match_wildcard function Du, Changbin
2013-11-16 8:24 ` [PATCH v5 2/3] dynamic_debug: add wildcard support to filter files/functions/modules Du, Changbin
2013-11-16 8:24 ` [PATCH v5 3/3] dynamic-debug-howto.txt: update since new wildcard support Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383063623.2713.12.camel@joe-AO722 \
--to=joe@perches.com \
--cc=changbin.du@gmail.com \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).