From: Jisheng Zhang <jszhang@marvell.com>
To: <rob.herring@calxeda.com>, <linux@arm.linux.org.uk>,
<kernel@pengutronix.de>, <baohua@kernel.org>,
<dinguyen@altera.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Jisheng Zhang <jszhang@marvell.com>
Subject: [PATCH v5 2/3] bus: mvebu: add missing of_node_put() to fix reference leak
Date: Thu, 7 Nov 2013 11:08:37 +0800 [thread overview]
Message-ID: <1383793720-4643-5-git-send-email-jszhang@marvell.com> (raw)
In-Reply-To: <1383793720-4643-1-git-send-email-jszhang@marvell.com>
Add of_node_put to properly decrement the refcount when we are
done using a given node.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/bus/mvebu-mbus.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 33c6947..20da90f 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -837,6 +837,7 @@ int __init mvebu_mbus_init(const char *soc, phys_addr_t mbuswins_phys_base,
{
struct mvebu_mbus_state *mbus = &mbus_state;
const struct of_device_id *of_id;
+ struct device_node *np;
int win;
for (of_id = of_mvebu_mbus_ids; of_id->compatible; of_id++)
@@ -860,8 +861,11 @@ int __init mvebu_mbus_init(const char *soc, phys_addr_t mbuswins_phys_base,
return -ENOMEM;
}
- if (of_find_compatible_node(NULL, NULL, "marvell,coherency-fabric"))
+ np = of_find_compatible_node(NULL, NULL, "marvell,coherency-fabric");
+ if (np) {
mbus->hw_io_coherency = 1;
+ of_node_put(np);
+ }
for (win = 0; win < mbus->soc->num_wins; win++)
mvebu_mbus_disable_window(mbus, win);
--
1.8.4.rc3
next prev parent reply other threads:[~2013-11-07 3:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 3:08 [PATCH 0/4] arm: make use of common scu_a9_get_base() interface Jisheng Zhang
2013-11-07 3:08 ` [PATCH 1/4] arm: highbank: " Jisheng Zhang
2013-11-07 3:08 ` [PATCH v5 1/3] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-11-07 17:55 ` Gregory CLEMENT
2013-11-07 3:08 ` [PATCH 2/4] arm: imx: make use of common scu_a9_get_base() interface Jisheng Zhang
2013-11-07 3:08 ` Jisheng Zhang [this message]
2013-11-07 17:56 ` [PATCH v5 2/3] bus: mvebu: add missing of_node_put() to fix reference leak Gregory CLEMENT
2013-11-07 3:08 ` [PATCH 3/4] arm: prima2: make use of common scu_a9_get_base() interface Jisheng Zhang
2013-11-07 3:08 ` [PATCH v5 3/3] pinctrl: mvebu: Convert to use devm_ioremap_resource Jisheng Zhang
2013-11-07 17:57 ` Gregory CLEMENT
2013-11-07 3:08 ` [PATCH 4/4] arm: socfgpa: make use of common scu_a9_get_base() interface Jisheng Zhang
2013-11-07 3:13 ` [PATCH 0/4] arm: " Jisheng Zhang
-- strict thread matches above, loose matches on Subject: below --
2013-08-27 4:41 [PATCH v5 0/3] arm: mvebu: fix resource leak Jisheng Zhang
2013-08-27 4:41 ` [PATCH v5 2/3] bus: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383793720-4643-5-git-send-email-jszhang@marvell.com \
--to=jszhang@marvell.com \
--cc=baohua@kernel.org \
--cc=dinguyen@altera.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).