From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
To: linux-i2c@vger.kernel.org
Cc: sjg@chromium.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, wsa@the-dreams.de,
ben-linux@fluff.org, grant.likely@secretlab.ca,
broonie@kernel.org, dianders@chromium.org, cpgs@samsung.com,
t.figa@samsung.com
Subject: [PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series
Date: Tue, 19 Nov 2013 11:48:35 +0530 [thread overview]
Message-ID: <1384841915-8264-1-git-send-email-ch.naveen@samsung.com> (raw)
In-Reply-To: <1381490814-20890-1-git-send-email-ch.naveen@samsung.com>
For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based
on a fixed 66 MHz peripheral clock, and therefore is completely
independent of the cpu frequency.
Thus, registering for a CPU freq notifier is very wasteful.
This patch modifes the code such that, i2c bus registers to
cpu_freq_transition only if CONFIG_CPU_FREQ_S3C24XX is enabled.
This change should save a bunch of cpufreq transitions calls
which does not apply to exynos SoCs.
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
Changes since v2:
None, Rebased on for-next of linux-i2c git repo.
Changes since v1:
Use CONFIG_CPU_FREQ_S3C24XX instead of (CONFIG_CPU_FREQ & !CONFIG_EXYNOS)
As commented by Tomasz
drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index bf8fb94..fa51dff 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -123,7 +123,7 @@ struct s3c24xx_i2c {
struct s3c2410_platform_i2c *pdata;
int gpios[2];
struct pinctrl *pctrl;
-#ifdef CONFIG_CPU_FREQ
+#if defined(CONFIG_CPU_FREQ_S3C24XX)
struct notifier_block freq_transition;
#endif
};
@@ -843,7 +843,7 @@ static int s3c24xx_i2c_clockrate(struct s3c24xx_i2c *i2c, unsigned int *got)
return 0;
}
-#ifdef CONFIG_CPU_FREQ
+#if defined(CONFIG_CPU_FREQ_S3C24XX)
#define freq_to_i2c(_n) container_of(_n, struct s3c24xx_i2c, freq_transition)
--
1.7.10.4
next prev parent reply other threads:[~2013-11-19 6:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 11:26 [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series Naveen Krishna Chatradhi
2013-10-12 2:22 ` Tomasz Figa
2013-10-12 2:28 ` Tomasz Figa
2013-10-12 5:42 ` Tomasz Figa
2013-10-12 6:36 ` Naveen Krishna Ch
2013-10-15 6:23 ` [PATCH v2] " Naveen Krishna Chatradhi
2013-10-15 6:56 ` Kyungmin Park
2013-10-15 15:38 ` Doug Anderson
2013-11-19 6:18 ` Naveen Krishna Chatradhi [this message]
2013-11-25 23:41 ` [PATCH v3] " Doug Anderson
2013-11-26 4:07 ` Naveen Krishna Ch
2013-11-26 4:22 ` [PATCH v4] " Naveen Krishna Chatradhi
2013-12-09 16:09 ` Tomasz Figa
2014-01-03 16:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384841915-8264-1-git-send-email-ch.naveen@samsung.com \
--to=ch.naveen@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cpgs@samsung.com \
--cc=dianders@chromium.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjg@chromium.org \
--cc=t.figa@samsung.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).