From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591Ab3K1JKS (ORCPT ); Thu, 28 Nov 2013 04:10:18 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:35154 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751965Ab3K1JKF (ORCPT ); Thu, 28 Nov 2013 04:10:05 -0500 X-IronPort-AV: E=Sophos;i="4.93,789,1378828800"; d="scan'208";a="9145482" From: Dongsheng Yang To: linux-kernel@vger.kernel.org Cc: eranian@google.com, dsahern@gmail.com, adrian.hunter@intel.com, acme@ghostprotocols.net, mingo@redhat.com, paulus@samba.org, a.p.zijlstra@chello.nl, Dongsheng Yang Subject: [PATCH] perf machine: Remove condition in machine__get_kernel_start_addr. Date: Thu, 28 Nov 2013 17:08:18 -0500 Message-Id: <1385676498-4348-1-git-send-email-yangds.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.8.2.1 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/11/28 17:10:02, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/11/28 17:10:06, Serialize complete at 2013/11/28 17:10:06 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In machine__get_kernel_start_addr, the code, which is using machine->root_dir to build filename, works for both host and guests initialized from guestmount. So this patch remove the branch for machine__is_host. Signed-off-by: Dongsheng Yang --- tools/perf/util/machine.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 84cdb07..bac817a 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -502,15 +502,11 @@ static u64 machine__get_kernel_start_addr(struct machine *machine) char path[PATH_MAX]; struct process_args args; - if (machine__is_host(machine)) { - filename = "/proc/kallsyms"; - } else { - if (machine__is_default_guest(machine)) - filename = (char *)symbol_conf.default_guest_kallsyms; - else { - sprintf(path, "%s/proc/kallsyms", machine->root_dir); - filename = path; - } + if (machine__is_default_guest(machine)) + filename = (char *)symbol_conf.default_guest_kallsyms; + else { + sprintf(path, "%s/proc/kallsyms", machine->root_dir); + filename = path; } if (symbol__restricted_filename(filename, "/proc/kallsyms")) -- 1.8.2.1