linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Bottomley@parallels.com, linux-scsi@vger.kernel.org,
	rkuo <rkuo@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"
Date: Sun, 01 Dec 2013 16:49:47 -0800	[thread overview]
Message-ID: <1385945387.20150.2.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <529BD584.7060504@gmail.com>

On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote:
> On 12/02/2013 12:17 AM, Bart Van Assche wrote:
> > On 11/27/13 03:29, Chen Gang wrote:
> >> the macro "SP" is too common to make conflict with some architectures,
> >> so recommend to add prefix for it.
> >>
> >> The related warning (with allmodconfig for hexagon):
> >>
> >>     CC [M]  drivers/scsi/scsi_lib.o
> >>   drivers/scsi/scsi_lib.c:46:0: warning: "SP" redefined [enabled by default]
> >>   arch/hexagon/include/uapi/asm/registers.h:9:0: note: this is the location of the previous definition
> >>
> >>
> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >> ---
> >>  drivers/scsi/scsi_lib.c |   16 ++++++++--------
> >>  1 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> >> index 7bd7f0d..f78e21b 100644
> >> --- a/drivers/scsi/scsi_lib.c
> >> +++ b/drivers/scsi/scsi_lib.c
> >> @@ -43,28 +43,28 @@ struct scsi_host_sg_pool {
> >>  	mempool_t	*pool;
> >>  };
> >>  
> >> -#define SP(x) { x, "sgpool-" __stringify(x) }
> >> +#define SCSILIB_SP(x) { x, "sgpool-" __stringify(x) }
> >>  #if (SCSI_MAX_SG_SEGMENTS < 32)
> >>  #error SCSI_MAX_SG_SEGMENTS is too small (must be 32 or greater)
> >>  #endif
> >>  static struct scsi_host_sg_pool scsi_sg_pools[] = {
> >> -	SP(8),
> >> -	SP(16),
> >> +	SCSILIB_SP(8),
> >> +	SCSILIB_SP(16),
> >>  #if (SCSI_MAX_SG_SEGMENTS > 32)
> >> -	SP(32),
> >> +	SCSILIB_SP(32),
> >>  #if (SCSI_MAX_SG_SEGMENTS > 64)
> >> -	SP(64),
> >> +	SCSILIB_SP(64),
> >>  #if (SCSI_MAX_SG_SEGMENTS > 128)
> >> -	SP(128),
> >> +	SCSILIB_SP(128),
> >>  #if (SCSI_MAX_SG_SEGMENTS > 256)
> >>  #error SCSI_MAX_SG_SEGMENTS is too large (256 MAX)
> >>  #endif
> >>  #endif
> >>  #endif
> >>  #endif
> >> -	SP(SCSI_MAX_SG_SEGMENTS)
> >> +	SCSILIB_SP(SCSI_MAX_SG_SEGMENTS)
> >>  };
> >> -#undef SP
> >> +#undef SCSILIB_SP
> >>  
> >>  struct kmem_cache *scsi_sdb_cache;
> > 
> > Sorry but the "SCSILIB_SP" name doesn't look very descriptive to me.
> > There are probably better choices possible. How about using e.g.
> > SG_POOL() instead ?
> > 
> 
> That sounds good to me, I will send patch v2, tomorrow (today I have
> to do some another urgent things, if this patch is also urgent, please
> help send). :-)

No, this is the wrong thing to do.  Exported headers should be namespace
protected, so the thing wrong is what's exporting the problem to us,
namely hexagon.

James



  reply	other threads:[~2013-12-02  0:49 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  4:57 [PATCH] arch: hexagon: Kconfig: add HAVE_DMA_ATTR in Kconfig and remove "linux/dma-mapping.h" from "asm/dma-mapping.h" Chen Gang
2013-11-25  1:19 ` rkuo
2013-11-25  2:39   ` [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" Chen Gang
2013-11-25  2:40     ` [PATCH 1/2] " Chen Gang
2013-11-25  2:41       ` [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() " Chen Gang
2013-11-28  8:51         ` [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members " Chen Gang
2013-12-06 18:22           ` rkuo
2013-11-26  4:36       ` [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" " Chen Gang
2013-11-27  2:29         ` [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP" Chen Gang
2013-12-01 16:17           ` Bart Van Assche
2013-12-02  0:34             ` Chen Gang
2013-12-02  0:49               ` James Bottomley [this message]
2013-12-02 10:14                 ` Chen Gang
2013-12-02 21:32                   ` rkuo
2013-12-03 11:42                     ` Chen Gang
2013-12-04  2:42                     ` [PATCH v2] drivers: scsi: scsi_lib.c: use SG_POOL instead of SP Chen Gang
2013-11-27  3:01         ` [PATCH] drivers: staging: ft1000: ft1000-usb: initialize 'status' with STATUS_SUCCESS in request_code_segment() Chen Gang
2013-11-27  9:18           ` Josh Triplett
2013-11-27  9:27             ` Chen Gang
2013-12-04  7:31               ` Chen Gang
2013-11-27  3:17         ` [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() Chen Gang
2013-11-27  3:21           ` Joe Perches
2013-11-27  3:40             ` Chen Gang
2013-11-27  3:48               ` [PATCH v2] " Chen Gang
2013-11-27  4:03                 ` Greg KH
2013-11-27  4:24                   ` Chen Gang
2013-11-27 10:43                     ` Dan Carpenter
2013-11-28  1:47                       ` Chen Gang
2013-11-27  3:40         ` [PATCH] drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl() Chen Gang
2013-11-27  4:53         ` [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case Chen Gang
2013-11-29 15:38           ` Johannes Berg
2013-11-30 11:59             ` Chen Gang
2013-11-30 12:53               ` Johannes Berg
2013-11-30 13:50                 ` Chen Gang
2013-11-30 14:02                   ` Chen Gang
2013-11-30 20:08                     ` Johannes Berg
2013-11-30 20:39                       ` Joe Perches
2013-11-30 23:48                         ` Chen Gang
2013-11-30 23:59                           ` Chen Gang
2013-12-01  9:37                           ` Johannes Berg
2013-12-01 11:50                             ` Chen Gang
2013-12-01  9:35                         ` Johannes Berg
2013-12-01 22:38                           ` Joe Perches
2013-12-02  0:45                             ` Chen Gang
2013-12-02 14:48                             ` Johannes Berg
2013-12-04  2:12                               ` Chen Gang
2013-12-04  8:04                                 ` Johannes Berg
2013-12-04  8:41                                   ` Chen Gang
2013-12-04  8:49                                     ` Johannes Berg
2013-12-04  9:00                                       ` Chen Gang
2013-11-27  5:28         ` [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ Chen Gang
2013-12-06 18:21           ` rkuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385945387.20150.2.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Bottomley@parallels.com \
    --cc=bvanassche@acm.org \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rkuo@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).