Re: [PATCH] expand micro-optimizations in kernel to newer model CPUs

From: John <da_audiophile@yahoo.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"david.heidelberger@ixit.cz" <david.heidelberger@ixit.cz>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] expand micro-optimizations in kernel to newer model CPUs
Date: Sun, 15 Dec 2013 04:42:50 -0800 (PST)	[thread overview]
Message-ID: <1387111370.81380.YahooMailNeo@web140001.mail.bf1.yahoo.com> (raw)
In-Reply-To: <CAFLxGvxakZS5FFQcZ_ogTd9aUENT3ECj2Lxs+FCbZAiGqgOJ7g@mail.gmail.com>

----- Original Message -----
> From: Richard Weinberger <>
>
> A *very* small speedup.
> 
> And I really doubt your numbers.
> Why are you using ANOVA? You're comparing *two* groups not more than two.
> I had a quick look at your raw numbers, they don't seem to be normally
> distributed at all.
> Did you remove some peaks?
> 

Hi Richard.  Thank you for your interest.  Yes, a small speedup as I mentioned but  I'll note that the current kernel code includes the MCORE2 option.  I tested this against some of the newer ones and they are all on par with each other.  For example, here are differences in median values:

CPUDifference in median value
core2        +87.5 ms
core7-avx+79.7 ms
core-avx-i+257.2 ms

I am using ANOVA to establish that the generic group differs from the optimized group.  I have always used ANOVA for this sort of comparison whether using two or more groups.  In fact, thumb through any medical or scientific journal, you'll see others in pier reviewed article doing the same.  

I did not remove any datapoints; I do not understand why you don't think the sets are normally distributed.  Did you see the normal quantile plots?  Additionally, the population variances are fairly equal (Levene and Barlett tests). 