From: Zhang Rui <rui.zhang@intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@linaro.org, gregkh@linuxfoundation.org,
rafael.j.wysocki@intel.com, grant.likely@linaro.org,
jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
grant.likely@secretlab.ca
Subject: Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices
Date: Thu, 16 Jan 2014 21:05:09 +0800 [thread overview]
Message-ID: <1389877509.3010.15.camel@rzhang1-mobl4> (raw)
In-Reply-To: <20140116122704.GD2617@katana>
On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote:
> > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> > index d74c0b3..c4c5588 100644
> > --- a/drivers/i2c/i2c-core.c
> > +++ b/drivers/i2c/i2c-core.c
> > @@ -104,6 +104,11 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
> > static int i2c_device_uevent(struct device *dev, struct kobj_uevent_env *env)
> > {
> > struct i2c_client *client = to_i2c_client(dev);
> > + int rc;
> > +
> > + rc = acpi_device_uevent_modalias(dev, env);
> > + if (rc != -ENODEV)
> > + return rc;
> >
> > if (add_uevent_var(env, "MODALIAS=%s%s",
> > I2C_MODULE_PREFIX, client->name))
>
> I wonder why we don't have/need that with CONFIG_OF? Because probably
> nobody is using modules with i2c devices there?
>
This seems a gap to me but I'm not 100% sure.
I saw Grant Likely introduced the OF style MODALIAS to platform bus, and
OF style registration/binding to i2c bus, maybe he has an answer for
this.
thanks,
rui
next prev parent reply other threads:[~2014-01-16 13:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:46 [PATCH 0/4] module autoloading fixes Zhang Rui
2014-01-14 8:46 ` [PATCH 1/4] ACPI: fix create_modalias() return value handling Zhang Rui
2014-01-15 15:02 ` Mika Westerberg
2014-01-14 8:46 ` [PATCH 2/4] ACPI: add module autoloading support for ACPI enumerated devices Zhang Rui
2014-01-14 8:46 ` [PATCH 3/4] fix module autoloading " Zhang Rui
2014-01-15 15:08 ` Mika Westerberg
2014-01-16 8:04 ` Zhang Rui
2014-01-17 1:28 ` Rafael J. Wysocki
2014-01-17 1:56 ` Zhang Rui
2014-01-16 12:27 ` Wolfram Sang
2014-01-16 13:05 ` Zhang Rui [this message]
2014-01-16 19:46 ` Mark Brown
2014-01-17 7:37 ` Jarkko Nikula
2014-01-17 15:57 ` Mark Brown
2014-01-20 7:10 ` Jarkko Nikula
2014-01-16 12:28 ` Mark Brown
2014-01-16 12:51 ` Zhang Rui
2014-01-16 19:24 ` Wolfram Sang
2014-01-14 8:46 ` [PATCH 4/4] OF: introduce OF style 'modalias' support for platform bus Zhang Rui
2014-01-15 13:45 ` Rob Herring
2014-01-16 1:09 ` Rafael J. Wysocki
2014-01-16 7:04 ` Zhang, Rui
2014-01-16 21:21 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2014-01-13 13:48 [PATCH 3/4] fix module autoloading for ACPI enumerated devices Zhang Rui
2014-01-13 17:35 ` Mark Brown
2014-01-14 8:00 ` Zhang Rui
2014-01-14 14:41 ` Mark Brown
2014-01-15 1:16 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389877509.3010.15.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=broonie@linaro.org \
--cc=grant.likely@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).