From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-rt-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
tglx@linutronix.de,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 2/2] timer: really raise softirq if there is irq_work to do
Date: Fri, 31 Jan 2014 15:34:05 +0100 [thread overview]
Message-ID: <1391178845-15837-2-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1391178845-15837-1-git-send-email-bigeasy@linutronix.de>
from looking at the code, it seems that the softirq is only raised (in
the !base->active_timers case) if we have also an expired timer
(time_before_eq() is true). This patch ensures that the timer softirq is
also raised in the !base->active_timers && no timer expired.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
kernel/timer.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index 6b3c172..b04c879 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1453,6 +1453,7 @@ static void run_timer_softirq(struct softirq_action *h)
void run_local_timers(void)
{
struct tvec_base *base = __this_cpu_read(tvec_bases);
+ bool need_raise = false;
hrtimer_run_queues();
/*
@@ -1470,12 +1471,17 @@ void run_local_timers(void)
#ifdef CONFIG_PREEMPT_RT_FULL
/* On RT, irq work runs from softirq */
if (!irq_work_needs_cpu())
-#endif
goto out;
+ need_raise = true;
+#else
+ goto out;
+#endif
}
/* Check whether the next pending timer has expired */
if (time_before_eq(base->next_timer, jiffies))
+ need_raise = true;
+ if (need_raise)
raise_softirq(TIMER_SOFTIRQ);
out:
#ifdef CONFIG_PREEMPT_RT_FULL
--
1.8.5.3
next prev parent reply other threads:[~2014-01-31 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 14:34 [PATCH 1/2] irq_work: allow certain work in hard irq context Sebastian Andrzej Siewior
2014-01-31 14:34 ` Sebastian Andrzej Siewior [this message]
2014-01-31 17:07 ` [PATCH 2/2] timer: really raise softirq if there is irq_work to do Steven Rostedt
2014-01-31 17:11 ` Steven Rostedt
2014-01-31 17:42 ` Paul E. McKenney
2014-01-31 17:57 ` Steven Rostedt
2014-01-31 19:03 ` Paul E. McKenney
2014-01-31 19:26 ` Sebastian Andrzej Siewior
2014-01-31 19:34 ` Steven Rostedt
2014-01-31 19:48 ` Sebastian Andrzej Siewior
2014-01-31 19:56 ` Steven Rostedt
2014-01-31 20:05 ` Peter Zijlstra
2014-01-31 20:23 ` Sebastian Andrzej Siewior
2014-01-31 20:29 ` Peter Zijlstra
2014-01-31 19:54 ` Peter Zijlstra
2014-01-31 19:06 ` Sebastian Andrzej Siewior
2014-02-02 4:22 ` [PATCH 1/2] irq_work: allow certain work in hard irq context Mike Galbraith
2014-02-02 20:10 ` Sebastian Andrzej Siewior
2014-02-03 2:43 ` Mike Galbraith
2014-02-03 4:00 ` Mike Galbraith
2014-02-03 8:31 ` Sebastian Andrzej Siewior
2014-02-03 9:26 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391178845-15837-2-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).