From: Robin Murphy <firstname.lastname@example.org> To: Will Deacon <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v7 0/6] Add non-strict mode support for iommu-dma Date: Tue, 18 Sep 2018 19:28:25 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20180918171000.GI16498@arm.com> Hi Will, On 2018-09-18 6:10 PM, Will Deacon wrote: > Hi Robin, > > Thanks for turning this around so quickly. Cheers for a pretty rapid review too :) > On Fri, Sep 14, 2018 at 03:30:18PM +0100, Robin Murphy wrote: >> Since we'd like to get this polished up and merged and Leizhen has other >> commitments, here's v7 of the previous series wherein I address all >> my own feedback :) This is a quick tweak of the v6 I sent yesterday >> since I figured out slightly too late a much neater way of setting the >> attribute at the appropriate time. >> >> The principal change is that I've inverted things slightly such that >> it's now a generic domain attribute controlled by iommu-dma given the >> necessary support from individual IOMMU drivers. That way we can easily >> enable other drivers straight away, as I've done for SMMUv2 here (which >> also allowed me to give it a quick test with MMU-401s on a Juno board). >> Otherwise it's really just cosmetic cleanup and rebasing onto Will's >> pending SMMU queue. > > I've been through and had a look, leaving some small comments on the patches > themselves. The only part I failed to figure out is how you tie the lifetime > of the flush queue to the lifetime of the domain so that the timer callback > can't fire after e.g. the DMA cookie has been freed. How does that work? Er, to be honest I haven't looked or even considered it! Other than the parts I've massaged I kinda took the functionality of the previous series for granted. Let me cross-check the x86 code and figure it out. Robin.
prev parent reply other threads:[~2018-09-18 18:28 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-14 14:30 Robin Murphy 2018-09-14 14:30 ` [PATCH v7 1/6] iommu/arm-smmu-v3: Implement flush_iotlb_all hook Robin Murphy 2018-09-14 14:30 ` [PATCH v7 2/6] iommu/dma: Add support for non-strict mode Robin Murphy 2018-09-18 17:10 ` Will Deacon 2018-09-18 18:52 ` Robin Murphy 2018-09-14 14:30 ` [PATCH v7 3/6] iommu/io-pgtable-arm: " Robin Murphy 2018-09-14 14:30 ` [PATCH v7 4/6] iommu: Add bootup option "iommu.non_strict" Robin Murphy 2018-09-18 17:10 ` Will Deacon 2018-09-18 19:01 ` Robin Murphy 2018-09-14 14:30 ` [PATCH v7 5/6] iommu/arm-smmu-v3: Add support for non-strict mode Robin Murphy 2018-09-18 17:10 ` Will Deacon 2018-09-18 19:09 ` Robin Murphy 2018-09-14 14:30 ` [PATCH v7 6/6] iommu/arm-smmu: Support " Robin Murphy 2018-09-18 17:10 ` Will Deacon 2018-09-18 19:22 ` Robin Murphy 2018-09-18 17:10 ` [PATCH v7 0/6] Add non-strict mode support for iommu-dma Will Deacon 2018-09-18 18:28 ` Robin Murphy [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v7 0/6] Add non-strict mode support for iommu-dma' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).