From: Sebastian Reichel <sre@debian.org>
To: Sebastian Reichel <sre@ring0.de>, Marek Belisko <marek@goldelico.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, Sebastian Reichel <sre@debian.org>
Subject: [RFCv1 2/4] mfd: twl4030-madc: Add DT support and convert to IIO framework
Date: Fri, 14 Feb 2014 19:46:24 +0100 [thread overview]
Message-ID: <1392403586-30540-2-git-send-email-sre@debian.org> (raw)
In-Reply-To: <1392403586-30540-1-git-send-email-sre@debian.org>
This converts twl4030-madc module to use the Industrial IO ADC
framework and adds device tree support.
Signed-off-by: Sebastian Reichel <sre@debian.org>
---
drivers/mfd/twl4030-madc.c | 121 ++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 114 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index 5458561..4da61c4 100644
--- a/drivers/mfd/twl4030-madc.c
+++ b/drivers/mfd/twl4030-madc.c
@@ -47,6 +47,10 @@
#include <linux/gfp.h>
#include <linux/err.h>
+#include <linux/iio/iio.h>
+#include <linux/iio/machine.h>
+#include <linux/iio/driver.h>
+
/*
* struct twl4030_madc_data - a container for madc info
* @dev - pointer to device structure for madc
@@ -59,10 +63,72 @@ struct twl4030_madc_data {
struct device *dev;
struct mutex lock; /* mutex protecting this data structure */
struct twl4030_madc_request requests[TWL4030_MADC_NUM_METHODS];
+ bool use_second_irq;
int imr;
int isr;
};
+static int twl4030_madc_read(struct iio_dev *iio_dev,
+ const struct iio_chan_spec *chan,
+ int *val, int *val2, long mask)
+{
+ struct twl4030_madc_data *madc = iio_priv(iio_dev);
+ struct twl4030_madc_request req;
+ int channel = chan->channel;
+ int ret;
+
+ req.method = madc->use_second_irq ? TWL4030_MADC_SW2 : TWL4030_MADC_SW1;
+
+ req.channels = BIT(channel);
+ req.active = 0;
+ req.func_cb = NULL;
+ req.raw = (mask & IIO_CHAN_INFO_PROCESSED) ? false : true;
+ req.do_avg = (mask & IIO_CHAN_INFO_AVERAGE_RAW) ? true : false;
+
+ ret = twl4030_madc_conversion(&req);
+ if (ret < 0)
+ return ret;
+
+ *val = req.rbuf[channel];
+
+ return IIO_VAL_INT;
+}
+
+static const struct iio_info twl4030_madc_iio_info = {
+ .read_raw = &twl4030_madc_read,
+ .driver_module = THIS_MODULE,
+};
+
+#define ADC_CHANNEL(_channel, _type, _name, _mask) { \
+ .type = _type, \
+ .scan_type = IIO_ST('u', 10, 16, 0), \
+ .channel = _channel, \
+ .info_mask_separate = _mask, \
+ .datasheet_name = _name, \
+ .indexed = 1, \
+}
+
+static const struct iio_chan_spec twl4030_madc_iio_channels[] = {
+ ADC_CHANNEL(0, IIO_VOLTAGE, "ADCIN0", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(1, IIO_TEMP, "ADCIN1", BIT(IIO_CHAN_INFO_PROCESSED) |
+ BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(2, IIO_VOLTAGE, "ADCIN2", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(3, IIO_VOLTAGE, "ADCIN3", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(4, IIO_VOLTAGE, "ADCIN4", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(5, IIO_VOLTAGE, "ADCIN5", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(6, IIO_VOLTAGE, "ADCIN6", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(7, IIO_VOLTAGE, "ADCIN7", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(8, IIO_VOLTAGE, "ADCIN8", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(9, IIO_VOLTAGE, "ADCIN9", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(10, IIO_CURRENT, "ADCIN10", BIT(IIO_CHAN_INFO_PROCESSED) |
+ BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(11, IIO_VOLTAGE, "ADCIN11", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(12, IIO_VOLTAGE, "ADCIN12", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(13, IIO_VOLTAGE, "ADCIN13", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(14, IIO_VOLTAGE, "ADCIN14", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+ ADC_CHANNEL(15, IIO_VOLTAGE, "ADCIN15", BIT(IIO_CHAN_INFO_AVERAGE_RAW)),
+};
+
static struct twl4030_madc_data *twl4030_madc;
struct twl4030_prescale_divider_ratios {
@@ -702,28 +768,49 @@ static int twl4030_madc_probe(struct platform_device *pdev)
{
struct twl4030_madc_data *madc;
struct twl4030_madc_platform_data *pdata = dev_get_platdata(&pdev->dev);
+ struct device_node *np = pdev->dev.of_node;
int irq, ret;
u8 regval;
+ struct iio_dev *iio_dev = NULL;
- if (!pdata) {
+ if (!pdata && !np) {
dev_err(&pdev->dev, "platform_data not available\n");
return -EINVAL;
}
- madc = devm_kzalloc(&pdev->dev, sizeof(*madc), GFP_KERNEL);
- if (!madc)
+
+ iio_dev = devm_iio_device_alloc(&pdev->dev,
+ sizeof(struct twl4030_madc_data));
+ if (!iio_dev) {
+ dev_err(&pdev->dev, "failed allocating iio device\n");
return -ENOMEM;
+ }
+ madc = iio_priv(iio_dev);
madc->dev = &pdev->dev;
+ iio_dev->name = dev_name(&pdev->dev);
+ iio_dev->dev.parent = &pdev->dev;
+ iio_dev->dev.of_node = pdev->dev.of_node;
+ iio_dev->info = &twl4030_madc_iio_info;
+ iio_dev->modes = INDIO_DIRECT_MODE;
+ iio_dev->channels = twl4030_madc_iio_channels;
+ iio_dev->num_channels = 16;
+
/*
* Phoenix provides 2 interrupt lines. The first one is connected to
* the OMAP. The other one can be connected to the other processor such
* as modem. Hence two separate ISR and IMR registers.
*/
- madc->imr = (pdata->irq_line == 1) ?
+ if (pdata)
+ madc->use_second_irq = pdata->irq_line != 1;
+ else
+ madc->use_second_irq = false;
+
+ madc->imr = (madc->use_second_irq == 1) ?
TWL4030_MADC_IMR1 : TWL4030_MADC_IMR2;
- madc->isr = (pdata->irq_line == 1) ?
+ madc->isr = (madc->use_second_irq == 1) ?
TWL4030_MADC_ISR1 : TWL4030_MADC_ISR2;
+
ret = twl4030_madc_set_power(madc, 1);
if (ret < 0)
return ret;
@@ -768,7 +855,7 @@ static int twl4030_madc_probe(struct platform_device *pdev)
}
}
- platform_set_drvdata(pdev, madc);
+ platform_set_drvdata(pdev, iio_dev);
mutex_init(&madc->lock);
irq = platform_get_irq(pdev, 0);
@@ -780,7 +867,15 @@ static int twl4030_madc_probe(struct platform_device *pdev)
goto err_i2c;
}
twl4030_madc = madc;
+
+ ret = iio_device_register(iio_dev);
+ if (ret) {
+ dev_dbg(&pdev->dev, "could not register iio device\n");
+ goto err_i2c;
+ }
+
return 0;
+
err_i2c:
twl4030_madc_set_current_generator(madc, 0, 0);
err_current_generator:
@@ -790,20 +885,32 @@ err_current_generator:
static int twl4030_madc_remove(struct platform_device *pdev)
{
- struct twl4030_madc_data *madc = platform_get_drvdata(pdev);
+ struct iio_dev *iio_dev = platform_get_drvdata(pdev);
+ struct twl4030_madc_data *madc = iio_priv(iio_dev);
twl4030_madc_set_current_generator(madc, 0, 0);
twl4030_madc_set_power(madc, 0);
+ iio_device_unregister(iio_dev);
+
return 0;
}
+#ifdef CONFIG_OF
+static const struct of_device_id twl_madc_of_match[] = {
+ {.compatible = "ti,twl4030-madc", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, twl_madc_of_match);
+#endif
+
static struct platform_driver twl4030_madc_driver = {
.probe = twl4030_madc_probe,
.remove = twl4030_madc_remove,
.driver = {
.name = "twl4030_madc",
.owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(twl_madc_of_match),
},
};
--
1.8.5.3
next prev parent reply other threads:[~2014-02-14 18:46 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 13:17 [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Marek Belisko
2014-02-14 13:17 ` [PATCH 2/2] ARM: dts: twl4030: Add twl4030-madc node Marek Belisko
2014-02-14 13:48 ` [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Lee Jones
2014-02-14 14:53 ` Belisko Marek
2014-02-14 15:28 ` Lee Jones
2014-02-14 17:40 ` Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 1/4] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-14 18:46 ` Sebastian Reichel [this message]
2014-02-15 13:31 ` [RFCv1 2/4] mfd: twl4030-madc: Add DT support and convert to IIO framework Belisko Marek
2014-02-16 9:02 ` Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 3/4] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 4/4] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-02-22 12:47 ` Jonathan Cameron
2014-02-23 0:35 ` Sebastian Reichel
2014-02-23 11:02 ` Jonathan Cameron
2014-02-23 22:01 ` Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 0/5] Convert twl4030-madc to IIO API Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 1/5] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 2/5] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 3/5] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 4/5] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 5/5] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-02-23 22:15 ` Joe Perches
2014-02-24 9:20 ` Peter Meerwald
2014-02-26 0:24 ` [RFCv3 0/7] Convert twl4030-madc to IIO API and add DT support Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 1/7] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 2/7] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-02-26 9:26 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 3/7] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-02-26 8:29 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 4/7] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-02-26 8:15 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 5/7] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-02-26 8:02 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 6/7] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 7/7] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-02-26 11:42 ` [RFCv3 0/7] Convert twl4030-madc to IIO API and add DT support Belisko Marek
2014-02-26 20:03 ` [RFCv4 " Sebastian Reichel
2014-02-26 20:03 ` [RFCv4 1/7] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-26 20:03 ` [RFCv4 2/7] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-02-27 8:23 ` Lee Jones
2014-03-01 11:33 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 3/7] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-02-27 8:03 ` Lee Jones
2014-03-01 11:41 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 4/7] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-03-01 11:48 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 5/7] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-03-01 11:49 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 6/7] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-03-01 11:50 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 7/7] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-03-01 11:51 ` Jonathan Cameron
2014-03-01 11:52 ` [RFCv4 0/7] Convert twl4030-madc to IIO API and add DT support Jonathan Cameron
2014-03-01 17:12 ` Sebastian Reichel
2014-03-03 8:00 ` Lee Jones
2014-03-01 19:32 ` [PATCHv1 0/9] " Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 1/9] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 2/9] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 3/9] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 4/9] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 5/9] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 6/9] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 7/9] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 8/9] iio: documentation: Add ABI documentation for *_mean_raw Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 9/9] iio: inkern: add iio_read_channel_average_raw Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 0/9] Convert twl4030-madc to IIO API and add DT support Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 1/9] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-03-15 15:19 ` Jonathan Cameron
2014-04-20 15:51 ` Pavel Machek
2014-03-04 22:05 ` [PATCHv2 2/9] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-03-05 1:40 ` Lee Jones
2014-03-15 15:23 ` Jonathan Cameron
2014-04-20 15:52 ` Pavel Machek
2014-03-04 22:05 ` [PATCHv2 3/9] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-03-15 15:25 ` Jonathan Cameron
2014-04-20 15:54 ` Pavel Machek
2014-03-04 22:05 ` [PATCHv2 4/9] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 5/9] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 6/9] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-03-15 15:27 ` Jonathan Cameron
2014-03-04 22:05 ` [PATCHv2 7/9] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 8/9] iio: documentation: Add ABI documentation for *_mean_raw Sebastian Reichel
2014-03-15 15:28 ` Jonathan Cameron
2014-03-04 22:05 ` [PATCHv2 9/9] iio: inkern: add iio_read_channel_average_raw Sebastian Reichel
2014-03-15 15:30 ` Jonathan Cameron
2014-03-05 21:00 ` [PATCHv2 0/9] Convert twl4030-madc to IIO API and add DT support Belisko Marek
2014-03-10 10:43 ` Lee Jones
2014-03-10 11:15 ` Sebastian Reichel
2014-02-24 16:05 ` [RFCv1 4/4] mfd: twl4030-madc: Move driver to drivers/iio/adc Lee Jones
2014-02-24 16:04 ` [RFCv1 1/4] mfd: twl4030-madc: Use managed resources Lee Jones
2014-02-15 13:37 ` [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392403586-30540-2-git-send-email-sre@debian.org \
--to=sre@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).