From: Alexey Perevalov <a.perevalov@samsung.com>
To: linux-kernel@vger.kernel.org, tglx@linutronix.de, john.stultz@linaro.org
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
anton@enomsg.org, kyungmin.park@samsung.com,
cw00.choi@samsung.com, akpm@linux-foundation.org
Subject: [PATCH v4 1/6] Replace ternary operator to macro
Date: Thu, 20 Feb 2014 20:23:40 +0400 [thread overview]
Message-ID: <1392913425-29369-2-git-send-email-a.perevalov@samsung.com> (raw)
In-Reply-To: <1392913425-29369-1-git-send-email-a.perevalov@samsung.com>
For extensibility purpose it's better to have _switch_ type mechanism
for representing human readable CLOCKID* and HRMODE.
Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com>
---
include/trace/events/timer.h | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index 68c2c20..185b2c6 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -8,6 +8,16 @@
#include <linux/hrtimer.h>
#include <linux/timer.h>
+#define clockid_to_string(clockid) \
+ __print_symbolic(clockid, \
+ { CLOCK_MONOTONIC, "CLOCK_MONOTONIC" }, \
+ { CLOCK_REALTIME, "CLOCK_REALTIME" })
+
+#define hrmode_to_string(hrmode) \
+ __print_symbolic(hrmode, \
+ { HRTIMER_MODE_ABS, "HRTIMER_MODE_ABS" }, \
+ { HRTIMER_MODE_REL, "HRTIMER_MODE_REL" })
+
DECLARE_EVENT_CLASS(timer_class,
TP_PROTO(struct timer_list *timer),
@@ -147,10 +157,8 @@ TRACE_EVENT(hrtimer_init,
),
TP_printk("hrtimer=%p clockid=%s mode=%s", __entry->hrtimer,
- __entry->clockid == CLOCK_REALTIME ?
- "CLOCK_REALTIME" : "CLOCK_MONOTONIC",
- __entry->mode == HRTIMER_MODE_ABS ?
- "HRTIMER_MODE_ABS" : "HRTIMER_MODE_REL")
+ clockid_to_string(__entry->clockid),
+ hrmode_to_string(__entry->mode))
);
/**
--
1.7.9.5
next prev parent reply other threads:[~2014-02-20 16:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 16:23 [PATCH v4 0/6] Deferrable timers support for hrtimers/timerfd API Alexey Perevalov
2014-02-20 16:23 ` Alexey Perevalov [this message]
2014-02-20 20:49 ` [PATCH v4 1/6] Replace ternary operator to macro Thomas Gleixner
2014-02-20 16:23 ` [PATCH v4 2/6] tracing/trivial: Add CLOCK_BOOTIME and CLOCK_TAI for human readable clockid trace Alexey Perevalov
2014-02-20 20:49 ` Thomas Gleixner
2014-02-20 16:23 ` [PATCH v4 3/6] hrtimer: Add support for deferrable timer into the hrtimer Alexey Perevalov
2014-02-20 16:23 ` [PATCH v4 4/6] timerfd: Move repeated logic into timerfd_rearm() Alexey Perevalov
2014-02-20 21:13 ` Thomas Gleixner
2014-02-20 16:23 ` [PATCH v4 5/6] timerfd: Add support for deferrable timers Alexey Perevalov
2014-02-26 2:53 ` Andy Lutomirski
2014-03-04 20:58 ` Thomas Gleixner
2014-03-04 21:53 ` Andy Lutomirski
2014-03-04 22:11 ` Thomas Gleixner
2014-03-04 22:43 ` Andy Lutomirski
2014-03-05 0:10 ` Thomas Gleixner
2014-03-05 0:42 ` Andy Lutomirski
2014-03-05 11:40 ` Thomas Gleixner
2014-03-05 9:42 ` Richard Cochran
2014-02-20 16:23 ` [PATCH v4 6/6] tracing/trivial: Add CLOCK_*_DEFERRABLE for tracing clockids Alexey Perevalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392913425-29369-2-git-send-email-a.perevalov@samsung.com \
--to=a.perevalov@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=john.stultz@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).