From: Joe Perches <joe@perches.com>
To: John Johansen <john.johansen@canonical.com>
Cc: linux-kernel@vger.kernel.org,
James Morris <james.l.morris@oracle.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/8] security: apparmor: Use a more current logging style
Date: Wed, 26 Feb 2014 06:43:16 -0800 [thread overview]
Message-ID: <1393425796.407.19.camel@joe-AO722> (raw)
In-Reply-To: <530D9862.1070108@canonical.com>
On Tue, 2014-02-25 at 23:31 -0800, John Johansen wrote:
> On 02/24/2014 01:59 PM, Joe Perches wrote:
> > Convert printks to pr_<level>.
> > Add pr_fmt.
> > Coalesce formats.
> > Remove embedded prefixes from logging.
> >
>
> you missed one place,
No, not really.
pr_debug differs from printk(KERN_DEBUG in that
pr_debug is only enabled with a #define DEBUG
or CONFIG_DYNAMIC_DEBUG setting.
I did not want to convert any of the printks
with KERN_DEBUG in this pass as that would
change the message logging by requiring
dynamic debugging be included in the CONFIG.
A subsequent pass converting these uses will
be done if or after these initial patches are
applied.
thanks, Joe
> --- a/security/apparmor/include/apparmor.h
> +++ b/security/apparmor/include/apparmor.h
> @@ -50,7 +50,7 @@ extern unsigned int aa_g_path_max;
> #define AA_DEBUG(fmt, args...) \
> do { \
> if (aa_g_debug && printk_ratelimit()) \
> - printk(KERN_DEBUG "AppArmor: " fmt, ##args); \
> + pr_debug(fmt, ##args); \
> } while (0)
>
> #define AA_ERROR(fmt, args...) \
>
> other than that looks good.
>
> > Signed-off-by: Joe Perches <joe@perches.com>
> Acked-by: John Johansen <john.johansen@canonical.com>
next prev parent reply other threads:[~2014-02-26 14:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 21:59 [PATCH 0/8] security: Use a more current logging style Joe Perches
2014-02-24 21:59 ` [PATCH 1/8] " Joe Perches
2014-02-25 19:10 ` Serge Hallyn
2014-02-25 19:34 ` Joe Perches
2014-02-25 19:41 ` [PATCH V2 " Joe Perches
2014-02-24 21:59 ` [PATCH 2/8] security: apparmor: " Joe Perches
2014-02-26 7:31 ` John Johansen
2014-02-26 14:43 ` Joe Perches [this message]
2014-02-24 21:59 ` [PATCH 3/8] security: integrity: " Joe Perches
2014-02-25 2:59 ` Mimi Zohar
2014-02-24 21:59 ` [PATCH 4/8] security: keys: " Joe Perches
2014-02-24 21:59 ` [PATCH 5/8] security: selinux: " Joe Perches
2014-02-25 20:05 ` Paul Moore
2014-02-25 20:20 ` Joe Perches
2014-02-24 21:59 ` [PATCH 6/8] security: smack: " Joe Perches
2014-02-24 22:16 ` Casey Schaufler
2014-02-24 22:23 ` Joe Perches
2014-02-24 22:33 ` Casey Schaufler
2014-02-24 22:35 ` Casey Schaufler
2014-02-24 23:01 ` Casey Schaufler
2014-02-25 7:47 ` James Morris
[not found] ` <17D2BA68-5581-4326-B6DD-5EC959235B71@aol.com>
2014-02-26 0:56 ` Joe Perches
2014-02-24 22:00 ` [PATCH 7/8] security: tomoyo: " Joe Perches
2014-02-25 12:58 ` Tetsuo Handa
2014-02-24 22:00 ` [PATCH 8/8] security: yama: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393425796.407.19.camel@joe-AO722 \
--to=joe@perches.com \
--cc=james.l.morris@oracle.com \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).