From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, matthew.garrett@nebula.com,
rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com
Subject: Re: [RFC PATCH 2/8] PNPACPI: use whilte list for pnpacpi device enumeration
Date: Mon, 10 Mar 2014 10:24:10 +0800 [thread overview]
Message-ID: <1394418250.10554.7.camel@rzhang1-mobl4> (raw)
In-Reply-To: <1493365.6dEb5KKfS7@vostro.rjw.lan>
On Sun, 2014-03-09 at 18:49 +0100, Rafael J. Wysocki wrote:
> On Sunday, March 09, 2014 01:29:30 PM Zhang Rui wrote:
> > On Fri, 2014-03-07 at 02:44 +0100, Rafael J. Wysocki wrote:
> > > On Wednesday, February 26, 2014 05:11:08 PM Zhang Rui wrote:
> > > > +
> > > > +static int __init acpi_pnp_scan_handler_attach(struct acpi_device *adev,
> > >
> > > This can't be __init.
> > >
> > > > + const struct acpi_device_id *id)
> > > > +{
> > > > + return 1;
> > > > +}
> > > > +
> > > > +static int __init acpi_pnp_scan_handler_match(char *devid, char *handlerid)
> > >
> > > And this too.
> > >
> > > > +{
> > > > + int i;
> > > > +
> > > > + if (!ispnpidacpi(devid))
> > > > + return 0;
> > > > +
> > > > + if (memcmp(devid, handlerid, 3))
> > > > + return 0;
> > > > +
> > > > + for (i = 3; i < 7; i++) {
> > > > + if (handlerid[i] != 'X' &&
> > > > + toupper(devid[i]) != toupper(handlerid[i]))
> > > > + return 0;
> > > > + }
> > > > + return 1;
> > > > +}
> > > > +
> > > > +static struct acpi_scan_handler pnpacpi_handler __initdata = {
> > >
> > > And this cannot be __initdata, because the list of ACPI scan handlers is
> > > walked during hotplug.
> > >
> > right. will update it in next version.
> >
> > > > + .ids = acpi_pnp_device_ids,
> > > > + .match = acpi_pnp_scan_handler_match,
> > > > + .attach = acpi_pnp_scan_handler_attach,
> > > > +};
> > > > +
> > > > +void __init acpi_pnp_init(void)
> > > > +{
> > > > + acpi_scan_add_handler(&pnpacpi_handler);
> > > > +}
> > > > +
> > > > +static acpi_status __init pnpacpi_add_device_handler(acpi_handle handle,
> > > > + u32 lvl, void *context,
> > > > + void **rv)
> > > > +{
> > > > + struct acpi_device *device;
> > > > +
> > > > + if (acpi_bus_get_device(handle, &device))
> > > > + return AE_CTRL_DEPTH;
> > > > + if (device->handler == &pnpacpi_handler)
> > > > + pnpacpi_add_device(device);
> > >
> > > Why don't you do that in acpi_pnp_scan_handler_attach() ?
> > >
> > because the PNP bus is not ready at that time.
>
> Do you mean it hasn't been initialized yet?
>
right.
both acpi_init() and pnp_init() are subsys_initcall, but pnp_init() is
invoked later because of the link order.
> But we can initialize it before the scan handler initialization, can't we?
>
well, I'm not sure, here is what I get from drivers/Makefile
obj-$(CONFIG_ACPI) += acpi/
obj-$(CONFIG_SFI) += sfi/
# PnP must come after ACPI since it will eventually need to check ifacpi
# was used and do nothing if so
obj-$(CONFIG_PNP) += pnp/
this comment was added long time ago and I do not know the background of
it, maybe Len knows the reason of this?
thanks,
rui
next prev parent reply other threads:[~2014-03-10 2:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:11 [RFC PATCH 0/8] ACPI: change the way of enumerating PNPACPI/Platform devices Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 1/8] ACPI: introduce .match() callback for ACPI scan handler Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 2/8] PNPACPI: use whilte list for pnpacpi device enumeration Zhang Rui
2014-03-07 1:44 ` Rafael J. Wysocki
2014-03-09 5:29 ` Zhang Rui
2014-03-09 17:49 ` Rafael J. Wysocki
2014-03-10 2:24 ` Zhang Rui [this message]
2014-02-26 9:11 ` [RFC PATCH 3/8] PNPACPI: remove ids that does not comply with the ACPI PNP id rule Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 4/8] PNPACPI: remove unsupported serial PNP ids from PNPACPI id list Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 5/8] PNPACPI: check and enumerate CMOS RTC devices explicitly Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 6/8] ACPI: use platform bus as the default bus for _HID enumeration Zhang Rui
2014-03-02 23:51 ` Rafael J. Wysocki
2014-03-03 14:11 ` Zhang Rui
2014-03-03 23:23 ` Rafael J. Wysocki
2014-03-04 0:27 ` Zhang, Rui
2014-03-04 0:35 ` Rafael J. Wysocki
2014-03-07 1:46 ` Rafael J. Wysocki
2014-03-09 5:33 ` Zhang Rui
2014-03-09 17:50 ` Rafael J. Wysocki
2014-03-09 15:50 ` Zhang Rui
2014-03-09 18:04 ` Rafael J. Wysocki
2014-03-10 2:44 ` Zhang Rui
2014-03-10 2:45 ` Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 7/8] Revert "ACPI / PNP: skip ACPI device nodes associated with physical nodes already" Zhang Rui
2014-02-26 9:11 ` [RFC PATCH 8/8] PNPACPI: create both PNP and Platform device nodes for PNP0C01/PNP0C02 Zhang Rui
2014-03-03 14:17 ` Zhang Rui
2014-03-03 16:17 ` Bjorn Helgaas
2014-02-26 16:47 ` [RFC PATCH 0/8] ACPI: change the way of enumerating PNPACPI/Platform devices Matthew Garrett
2014-03-03 13:50 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394418250.10554.7.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).