linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: atull@altera.com
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	dinguyen@altera.com, delicious.quinoa@gmail.com,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 6/7] gpio: dwapb: use a second irq chip
Date: Sat, 22 Mar 2014 17:16:43 +0100	[thread overview]
Message-ID: <1395505004-22650-7-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1395505004-22650-1-git-send-email-bigeasy@linutronix.de>

Right new have one irq chip running always in level mode. It would nicer
to have two irq chips where one is handling level type interrupts and
the other one is doing edge interrupts. So we can have at runtime two users
where one is using edge and the other level.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/gpio/gpio-dwapb.c | 41 ++++++++++++++++++++++++++++-------------
 1 file changed, 28 insertions(+), 13 deletions(-)

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 752ccb1..3c9cdda 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -192,6 +192,8 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
 		break;
 	}
 
+	irq_setup_alt_chip(d, type);
+
 	writel(level, gpio->regs + GPIO_INTTYPE_LEVEL);
 	writel(polarity, gpio->regs + GPIO_INT_POLARITY);
 	irq_gc_unlock(igc);
@@ -207,7 +209,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
 	struct irq_chip_generic	*irq_gc;
 	unsigned int hwirq, ngpio = gc->ngpio;
 	struct irq_chip_type *ct;
-	int err, irq;
+	int err, irq, i;
 
 	irq = irq_of_parse_and_map(node, 0);
 	if (!irq) {
@@ -221,7 +223,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
 	if (!gpio->domain)
 		return;
 
-	err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 1,
+	err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 2,
 					     "gpio-dwapb", handle_level_irq,
 					     IRQ_NOREQUEST, 0,
 					     IRQ_GC_INIT_NESTED_LOCK);
@@ -242,17 +244,28 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
 	irq_gc->reg_base = gpio->regs;
 	irq_gc->private = gpio;
 
-	ct = irq_gc->chip_types;
-	ct->chip.irq_ack = irq_gc_ack_set_bit;
-	ct->chip.irq_mask = irq_gc_mask_set_bit;
-	ct->chip.irq_unmask = irq_gc_mask_clr_bit;
-	ct->chip.irq_set_type = dwapb_irq_set_type;
-	ct->chip.irq_enable = dwapb_irq_enable;
-	ct->chip.irq_disable = dwapb_irq_disable;
-	ct->chip.irq_request_resources = dwapb_irq_reqres;
-	ct->chip.irq_release_resources = dwapb_irq_relres;
-	ct->regs.ack = GPIO_PORTA_EOI;
-	ct->regs.mask = GPIO_INTMASK;
+	for (i = 0; i < 2; i++) {
+
+		ct = &irq_gc->chip_types[i];
+		ct->chip.irq_ack = irq_gc_ack_set_bit;
+		ct->chip.irq_mask = irq_gc_mask_set_bit;
+		ct->chip.irq_unmask = irq_gc_mask_clr_bit;
+		ct->chip.irq_set_type = dwapb_irq_set_type;
+		ct->chip.irq_enable = dwapb_irq_enable;
+		ct->chip.irq_disable = dwapb_irq_disable;
+		ct->chip.irq_request_resources = dwapb_irq_reqres;
+		ct->chip.irq_release_resources = dwapb_irq_relres;
+		ct->regs.ack = GPIO_PORTA_EOI;
+		ct->regs.mask = GPIO_INTMASK;
+
+		if (i == 0) {
+			ct->type = IRQ_TYPE_LEVEL_MASK;
+			ct->handler = handle_level_irq;
+		} else {
+			ct->type = IRQ_TYPE_EDGE_BOTH;
+			ct->handler = handle_edge_irq;
+		}
+	}
 
 	irq_set_chained_handler(irq, dwapb_irq_handler);
 	irq_set_handler_data(irq, gpio);
-- 
1.9.1


  parent reply	other threads:[~2014-03-22 16:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-22 16:16 dwapb: a bug fix a few cleanups, v2 Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 1/7] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-05-05 22:02   ` Olof Johansson
2014-05-06 15:01     ` Alan Tull
2014-05-13  8:45     ` Linus Walleij
2014-03-22 16:16 ` [PATCH 2/7] gpio: dwapb: correct gpio-cells in binding document Sebastian Andrzej Siewior
2014-03-25 20:49   ` Linus Walleij
2014-03-25 20:57     ` Sebastian Andrzej Siewior
2014-03-25 21:00       ` Linus Walleij
2014-03-22 16:16 ` [PATCH 3/7] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 4/7] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 5/7] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-03-22 16:16 ` Sebastian Andrzej Siewior [this message]
2014-03-25 18:48   ` [PATCH 6/7] gpio: dwapb: use a second irq chip delicious quinoa
2014-03-25 19:40     ` Sebastian Andrzej Siewior
2014-03-25 21:36   ` Sebastian Hesselbarth
2014-04-07  9:59     ` Sebastian Andrzej Siewior
2014-04-08 15:11       ` delicious quinoa
2014-04-30 11:13         ` [PATCH 6/7 v2] " Sebastian Andrzej Siewior
2014-05-09 11:46           ` Linus Walleij
2014-05-13 16:17             ` Alan Tull
2014-05-16 15:01           ` Linus Walleij
2014-05-22  9:42             ` Sebastian Andrzej Siewior
2014-05-22 14:08               ` Alan Tull
2014-05-26 21:02                 ` Sebastian Andrzej Siewior
2014-05-26 20:58             ` [PATCH v3] " Sebastian Andrzej Siewior
2014-05-27  9:55               ` Jamie Iles
2014-05-27 14:21               ` Linus Walleij
2014-05-27 16:30                 ` Sebastian Andrzej Siewior
2014-05-28  9:01                   ` Linus Walleij
2014-05-28  9:26                     ` Sebastian Andrzej Siewior
2014-03-22 16:16 ` [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit) Sebastian Andrzej Siewior
2014-03-25  2:17   ` Alexandre Courbot
2014-03-25  7:54     ` Sebastian Andrzej Siewior
2014-03-25 21:18     ` [PATCH 7/7 v2] " Sebastian Andrzej Siewior
2014-03-25 21:25       ` Joe Perches
2014-03-25 20:45 ` dwapb: a bug fix a few cleanups, v2 Linus Walleij
2014-03-25 21:26   ` Sebastian Hesselbarth
2014-03-25 21:39     ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395505004-22650-7-git-send-email-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=atull@altera.com \
    --cc=delicious.quinoa@gmail.com \
    --cc=dinguyen@altera.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).