From: Arnd Bergmann <arnd@arndb.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org,
Michal Nazarewicz <mina86@mina86.com>,
Andrew Morton <akpm@linux-foundation.org>,
Grant Likely <grant.likely@linaro.org>,
Laura Abbott <lauraa@codeaurora.org>,
Josh Cartwright <joshc@codeaurora.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
rmk+kernel@arm.linux.org.uk
Subject: Re: [PATCH v3] drivers: of: add return value to of_reserved_mem_device_init
Date: Mon, 13 Oct 2014 13:19:09 +0200 [thread overview]
Message-ID: <13963062.ORRNOhrvYD@wuerfel> (raw)
In-Reply-To: <1412857080-5100-1-git-send-email-m.szyprowski@samsung.com>
On Thursday 09 October 2014 14:18:00 Marek Szyprowski wrote:
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 59fb12e..70780ad 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> if (!rmem || !rmem->ops || !rmem->ops->device_init)
> - return;
> + return -EINVAL;
>
> rmem->ops->device_init(rmem, dev);
> dev_info(dev, "assigned reserved memory node %s\n", rmem->name);
> + return 0;
> }
You don't actually return the value from ->device_init() here but always
return 0 on success. There are no callers of this function, so it's
hard to tell if this actually makes a difference, but it contradicts
your patch description.
> diff --git a/include/linux/of_reserved_mem.h b/include/linux/of_reserved_mem.h
> index 5b5efae..ad2f670 100644
> --- a/include/linux/of_reserved_mem.h
> +++ b/include/linux/of_reserved_mem.h
> @@ -16,7 +16,7 @@ struct reserved_mem {
> };
>
> struct reserved_mem_ops {
> - void (*device_init)(struct reserved_mem *rmem,
> + int (*device_init)(struct reserved_mem *rmem,
> struct device *dev);
> void (*device_release)(struct reserved_mem *rmem,
> struct device *dev);
This part is definitely needed to avoid the new compile warnings we
are getting.
Arnd
next prev parent reply other threads:[~2014-10-13 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 11:22 [PATCH v2 0/3] CMA & device tree, another approach Marek Szyprowski
2014-09-11 11:22 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init Marek Szyprowski
2014-09-26 6:44 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init (fixup) Marek Szyprowski
2014-09-27 13:58 ` Fabio Estevam
2014-09-26 20:13 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init Arnd Bergmann
2014-10-09 12:18 ` [PATCH v3] " Marek Szyprowski
2014-10-13 11:19 ` Arnd Bergmann [this message]
2014-10-15 11:01 ` [PATCH v4] " Marek Szyprowski
2014-10-20 19:04 ` [Linaro-mm-sig] " Arnd Bergmann
2014-09-11 11:22 ` [PATCH v2 2/3] drivers: dma-coherent: add initialization from device tree Marek Szyprowski
2014-09-24 22:26 ` Andrew Morton
2014-09-24 22:28 ` Andrew Morton
2014-09-11 11:22 ` [PATCH v2 3/3] drivers: dma-contiguous: " Marek Szyprowski
2014-09-23 8:05 ` [PATCH v2 0/3] CMA & device tree, another approach Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13963062.ORRNOhrvYD@wuerfel \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=grant.likely@linaro.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=joshc@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=lauraa@codeaurora.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).