From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, matthew.garrett@nebula.com,
rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com
Subject: Re: [PATCH V5 06/12] ACPI: introduce platform_id flag
Date: Mon, 28 Apr 2014 09:51:24 +0800 [thread overview]
Message-ID: <1398649884.2443.7.camel@rzhang1-mobl4> (raw)
In-Reply-To: <2359355.Scs9im2VU5@vostro.rjw.lan>
On Mon, 2014-04-28 at 00:20 +0200, Rafael J. Wysocki wrote:
> On Tuesday, April 08, 2014 12:06:53 AM Zhang Rui wrote:
> > Only certain kind of ACPI device objects can be enumerated to platform bus.
> > These ACPI device objects include
> > 1. ACPI device objects that have _HID control method.
> > 2. some ACPI device objects that have Linux specified HID strings.
> >
> > In order to distinguish those device objects from the others, a new flag
> > platform_id and a new function acpi_add_platform_id() are introduced
> > in this patch.
> >
> > Currently, only devices with _HID method have this flag set.
> > If you want platform devices to be created for device objects without _HID,
> > use acpi_add_platform_id() when adding artificial Linux-specific ID strings
> > to them.
> >
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
> It looks like [12/12] should be folded into this one or bisection may be broken
> for somebody.
>
agreed.
thanks,
rui
> > ---
> > drivers/acpi/scan.c | 9 ++++++++-
> > include/acpi/acpi_bus.h | 3 ++-
> > 2 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > index c82ab73..451e7d9 100644
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -1730,6 +1730,13 @@ static void acpi_add_id(struct acpi_device_pnp *pnp, const char *dev_id)
> > pnp->type.hardware_id = 1;
> > }
> >
> > +static void acpi_add_platform_id(struct acpi_device_pnp *pnp,
> > + const char *dev_id)
> > +{
> > + acpi_add_id(pnp, dev_id);
> > + pnp->type.platform_id = 1;
> > +}
> > +
> > /*
> > * Old IBM workstations have a DSDT bug wherein the SMBus object
> > * lacks the SMBUS01 HID and the methods do not have the necessary "_"
> > @@ -1794,7 +1801,7 @@ static void acpi_set_pnp_ids(acpi_handle handle, struct acpi_device_pnp *pnp,
> > }
> >
> > if (info->valid & ACPI_VALID_HID)
> > - acpi_add_id(pnp, info->hardware_id.string);
> > + acpi_add_platform_id(pnp, info->hardware_id.string);
> > if (info->valid & ACPI_VALID_CID) {
> > cid_list = &info->compatible_id_list;
> > for (i = 0; i < cid_list->count; i++)
> > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> > index ba679af..ec92ad3 100644
> > --- a/include/acpi/acpi_bus.h
> > +++ b/include/acpi/acpi_bus.h
> > @@ -233,7 +233,8 @@ struct acpi_hardware_id {
> > struct acpi_pnp_type {
> > u32 hardware_id:1;
> > u32 bus_address:1;
> > - u32 reserved:30;
> > + u32 platform_id:1;
> > + u32 reserved:29;
> > };
> >
> > struct acpi_device_pnp {
> >
>
next prev parent reply other threads:[~2014-04-28 1:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 16:06 [PATCH V5 00/12] ACPI: change the way of enumerating PNPACPI/Platform devices Zhang Rui
2014-04-07 16:06 ` [PATCH V5 01/12] ACPI: introduce .match() callback for ACPI scan handler Zhang Rui
2014-04-07 16:06 ` [PATCH V5 02/12] PNPACPI: use whilte list for pnpacpi device enumeration Zhang Rui
2014-04-27 22:01 ` Rafael J. Wysocki
2014-04-28 1:40 ` Zhang Rui
2014-04-28 20:35 ` Rafael J. Wysocki
2014-04-28 20:44 ` Bjorn Helgaas
2014-04-07 16:06 ` [PATCH V5 03/12] ACPI: remove ids that does not comply with the ACPI PNP id rule Zhang Rui
2014-04-07 16:06 ` [PATCH V5 04/12] ACPI: remove unsupported serial PNP ids from acpi pnp scan handler id lsit Zhang Rui
2014-04-07 16:06 ` [PATCH V5 05/12] ACPI: check and enumerate CMOS RTC devices explicitly Zhang Rui
2014-04-27 22:17 ` Rafael J. Wysocki
2014-04-27 22:19 ` Rafael J. Wysocki
2014-04-28 1:50 ` Zhang Rui
2014-04-07 16:06 ` [PATCH V5 06/12] ACPI: introduce platform_id flag Zhang Rui
2014-04-27 22:20 ` Rafael J. Wysocki
2014-04-28 1:51 ` Zhang Rui [this message]
2014-04-07 16:06 ` [PATCH V5 07/12] ACPI: use platform bus as the default bus for _HID enumeration Zhang Rui
2014-04-07 16:06 ` [PATCH V5 08/12] ACPI: introduce dummy lpss scan handler Zhang Rui
2014-04-27 22:23 ` Rafael J. Wysocki
2014-04-28 1:57 ` Zhang Rui
2014-04-07 16:06 ` [PATCH V5 09/12] ACPI: introduce acpi platform exclude id list Zhang Rui
2014-04-27 22:21 ` Rafael J. Wysocki
2014-04-28 1:57 ` Zhang Rui
2014-04-28 20:31 ` Rafael J. Wysocki
2014-04-07 16:06 ` [PATCH V5 10/12] ACPI: introduce dummy container scan handler Zhang Rui
2014-04-07 16:06 ` [PATCH V5 11/12] ACPI: introduce dummy memory hotplug " Zhang Rui
2014-04-07 16:06 ` [PATCH V5 12/12] ACPI: introduce .handle_children flag for acpi " Zhang Rui
2014-04-27 22:26 ` Rafael J. Wysocki
2014-04-28 2:07 ` Zhang Rui
2014-04-28 20:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398649884.2443.7.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).