From: Jiri Slaby <jslaby@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: jirislaby@gmail.com, Vojtech Pavlik <vojtech@suse.cz>,
Michael Matz <matz@suse.de>, Jiri Kosina <jkosina@suse.cz>,
Jiri Slaby <jslaby@suse.cz>, Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: [RFC 10/16] kgr: kthreads support
Date: Wed, 30 Apr 2014 16:30:43 +0200 [thread overview]
Message-ID: <1398868249-26169-11-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1398868249-26169-1-git-send-email-jslaby@suse.cz>
Wake up kthreads so that they cycle through kgr_task_safe either
by explicit call to it or implicitly via kthread_should_stop. This
ensures nobody should use the old version of the code and kgraft core
can push everybody to use the new version by switching to the fast
path.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
---
arch/x86/include/asm/kgr.h | 2 +-
kernel/kgr.c | 25 +++++++++++++++----------
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/arch/x86/include/asm/kgr.h b/arch/x86/include/asm/kgr.h
index 172f7b966bb5..49daa46243fc 100644
--- a/arch/x86/include/asm/kgr.h
+++ b/arch/x86/include/asm/kgr.h
@@ -13,7 +13,7 @@ static void _new_function ##_stub_slow (unsigned long ip, unsigned long parent_i
{ \
struct kgr_loc_caches *c = ops->private; \
\
- if (task_thread_info(current)->kgr_in_progress && current->mm) {\
+ if (task_thread_info(current)->kgr_in_progress) { \
pr_info("kgr: slow stub: calling old code at %lx\n", \
c->old); \
regs->ip = c->old + MCOUNT_INSN_SIZE; \
diff --git a/kernel/kgr.c b/kernel/kgr.c
index 5e9a07faddb9..ea63e857a78a 100644
--- a/kernel/kgr.c
+++ b/kernel/kgr.c
@@ -42,11 +42,7 @@ static bool kgr_still_patching(void)
read_lock(&tasklist_lock);
for_each_process(p) {
- /*
- * TODO
- * kernel thread codepaths not supported and silently ignored
- */
- if (task_thread_info(p)->kgr_in_progress && p->mm) {
+ if (task_thread_info(p)->kgr_in_progress) {
pr_info("pid %d (%s) still in kernel after timeout\n",
p->pid, p->comm);
failed = true;
@@ -94,13 +90,23 @@ static void kgr_work_fn(struct work_struct *work)
mutex_unlock(&kgr_in_progress_lock);
}
-static void kgr_mark_processes(void)
+static void kgr_handle_processes(void)
{
struct task_struct *p;
read_lock(&tasklist_lock);
- for_each_process(p)
+ for_each_process(p) {
task_thread_info(p)->kgr_in_progress = true;
+
+ /* wake up kthreads, they will clean the progress flag */
+ if (!p->mm) {
+ /*
+ * this is incorrect for kthreads waiting still for
+ * their first wake_up.
+ */
+ wake_up_process(p);
+ }
+ }
read_unlock(&tasklist_lock);
}
@@ -237,8 +243,7 @@ static int kgr_patch_code(const struct kgr_patch_fun *patch_fun, bool final)
* kgr_start_patching -- the entry for a kgraft patch
* @patch: patch to be applied
*
- * Start patching of code that is neither running in IRQ context nor
- * kernel thread.
+ * Start patching of code that is not running in IRQ context.
*/
int kgr_start_patching(const struct kgr_patch *patch)
{
@@ -276,7 +281,7 @@ int kgr_start_patching(const struct kgr_patch *patch)
kgr_patch = patch;
mutex_unlock(&kgr_in_progress_lock);
- kgr_mark_processes();
+ kgr_handle_processes();
/*
* give everyone time to exit kernel, and check after a while
--
1.9.2
next prev parent reply other threads:[~2014-04-30 14:34 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 14:30 [RFC 00/16] kGraft Jiri Slaby
2014-04-30 14:30 ` [RFC 01/16] ftrace: Add function to find fentry of function Jiri Slaby
2014-04-30 14:48 ` Steven Rostedt
2014-04-30 14:58 ` Jiri Slaby
2014-04-30 14:30 ` [RFC 02/16] ftrace: Make ftrace_is_dead available globally Jiri Slaby
2014-04-30 14:30 ` [RFC 03/16] kgr: initial code Jiri Slaby
2014-04-30 14:56 ` Steven Rostedt
2014-04-30 14:57 ` Jiri Slaby
2014-05-01 20:20 ` Andi Kleen
2014-05-01 20:37 ` Jiri Kosina
2014-05-14 9:28 ` Aravinda Prasad
2014-05-14 10:12 ` Jiri Slaby
2014-05-14 10:41 ` Aravinda Prasad
2014-05-14 10:44 ` Jiri Slaby
2014-05-14 11:19 ` Aravinda Prasad
2014-05-20 11:36 ` Jiri Slaby
2014-05-21 18:28 ` Aravinda Prasad
2014-05-26 8:50 ` Jiri Kosina
2014-04-30 14:30 ` [RFC 04/16] kgr: add testing kgraft patch Jiri Slaby
2014-05-06 11:03 ` Pavel Machek
2014-05-12 12:50 ` Jiri Slaby
2014-04-30 14:30 ` [RFC 05/16] kgr: update Kconfig documentation Jiri Slaby
2014-05-03 14:32 ` Randy Dunlap
2014-04-30 14:30 ` [RFC 06/16] kgr: add Documentation Jiri Slaby
2014-05-06 11:03 ` Pavel Machek
2014-05-09 9:31 ` kgr: dealing with optimalizations? (was Re: [RFC 06/16] kgr: add Documentat)ion Pavel Machek
2014-05-09 12:22 ` Michael Matz
2014-04-30 14:30 ` [RFC 07/16] kgr: trigger the first check earlier Jiri Slaby
2014-04-30 14:30 ` [RFC 08/16] kgr: sched.h, introduce kgr_task_safe helper Jiri Slaby
2014-04-30 14:30 ` [RFC 09/16] kgr: mark task_safe in some kthreads Jiri Slaby
2014-04-30 15:49 ` Greg Kroah-Hartman
2014-04-30 16:55 ` Paul E. McKenney
2014-04-30 18:33 ` Vojtech Pavlik
2014-04-30 19:07 ` Paul E. McKenney
2014-05-01 14:24 ` Tejun Heo
2014-05-01 20:17 ` Jiri Kosina
2014-05-01 21:02 ` Tejun Heo
2014-05-01 21:09 ` Tejun Heo
2014-05-14 14:59 ` Jiri Slaby
2014-05-14 15:15 ` Vojtech Pavlik
2014-05-14 15:30 ` Paul E. McKenney
2014-05-14 16:32 ` Tejun Heo
2014-05-15 3:53 ` Mike Galbraith
2014-05-15 4:06 ` Tejun Heo
2014-05-15 4:46 ` Mike Galbraith
2014-05-15 4:50 ` Tejun Heo
2014-05-15 5:04 ` Mike Galbraith
2014-05-15 5:09 ` Tejun Heo
2014-05-15 5:32 ` Mike Galbraith
2014-05-15 6:05 ` Tejun Heo
2014-05-15 6:32 ` Mike Galbraith
2014-04-30 14:30 ` Jiri Slaby [this message]
2014-04-30 14:30 ` [RFC 11/16] kgr: handle irqs Jiri Slaby
2014-04-30 14:30 ` [RFC 12/16] kgr: add tools Jiri Slaby
2014-05-06 11:03 ` Pavel Machek
2014-04-30 14:30 ` [RFC 13/16] kgr: add MAINTAINERS entry Jiri Slaby
2014-04-30 14:30 ` [RFC 14/16] kgr: x86: refuse to build without fentry support Jiri Slaby
2014-04-30 14:30 ` [RFC 15/16] kgr: add procfs interface for per-process 'kgr_in_progress' Jiri Slaby
2014-04-30 14:30 ` [RFC 16/16] kgr: make a per-process 'in progress' flag a single bit Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398868249-26169-11-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=fweisbec@gmail.com \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).