linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <davidlohr@hp.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, peterz@infradead.org,
	peter@hurleysoftware.com, jason.low2@hp.com, riel@redhat.com,
	alex.shi@linaro.org, paulmck@linux.vnet.ibm.com,
	akpm@linux-foundation.org, tglx@linutronix.de, walken@google.com,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [tip:locking/core] rwsem: Add comments to explain the meaning of the rwsem's count field
Date: Mon, 05 May 2014 19:30:37 -0700	[thread overview]
Message-ID: <1399343437.2498.3.camel@buesod1.americas.hpqcorp.net> (raw)
In-Reply-To: <1399330276.2970.207.camel@schen9-DESK>

On Mon, 2014-05-05 at 15:51 -0700, Tim Chen wrote:
> On Mon, 2014-05-05 at 20:27 +0200, Ingo Molnar wrote:
> 
> > > Ingo,
> > > 
> > > The delta patch is included below.  Thinking a bit more,
> > > the state diagram approach is not necessarily less verbose
> > > because the state is a tuple (count, wait queue state).
> > > After enumerating the states, we may wind up with very similar
> > > to what I have.
> > 
> > Could we at least try with one diagram and see how it goes?
> > 
> 
> I've tried (see below).  But I don't like how it came out :(

And quite nice, thanks for doing this. Personally, however, I much
prefer the already applied patch to this approach.

Thanks,
Davidlohr


  reply	other threads:[~2014-05-06  2:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 19:53 [PATCH v2] rwsem: Comments to explain the meaning of the rwsem's count field Tim Chen
2014-05-05  8:46 ` [tip:locking/core] rwsem: Add comments " tip-bot for Tim Chen
2014-05-05 16:03   ` Tim Chen
2014-05-05 16:31     ` Peter Zijlstra
2014-05-05 16:59       ` Tim Chen
2014-05-05 17:26     ` Ingo Molnar
2014-05-05 18:21       ` Tim Chen
2014-05-05 18:27         ` Ingo Molnar
2014-05-05 22:51           ` Tim Chen
2014-05-06  2:30             ` Davidlohr Bueso [this message]
2014-05-14 14:27   ` Davidlohr Bueso
2014-05-14 14:53     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399343437.2498.3.camel@buesod1.americas.hpqcorp.net \
    --to=davidlohr@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@linaro.org \
    --cc=hpa@zytor.com \
    --cc=jason.low2@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).