From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbaEFWIG (ORCPT ); Tue, 6 May 2014 18:08:06 -0400 Received: from g2t2354.austin.hp.com ([15.217.128.53]:44210 "EHLO g2t2354.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbaEFWIF (ORCPT ); Tue, 6 May 2014 18:08:05 -0400 Message-ID: <1399414081.30629.2.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH 0/4] ipc/shm.c: increase the limits for SHMMAX, SHMALL From: Davidlohr Bueso To: mtk.manpages@gmail.com Cc: Manfred Spraul , Davidlohr Bueso , Martin Schwidefsky , LKML , Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Greg Thelen , aswin@hp.com, "linux-mm@kvack.org" Date: Tue, 06 May 2014 15:08:01 -0700 In-Reply-To: References: <1398090397-2397-1-git-send-email-manfred@colorfullife.com> <1399406800.13799.20.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-05-06 at 22:40 +0200, Michael Kerrisk (man-pages) wrote: > Hi Davidlohr, > > On Tue, May 6, 2014 at 10:06 PM, Davidlohr Bueso wrote: > > On Fri, 2014-05-02 at 15:16 +0200, Michael Kerrisk (man-pages) wrote: > >> Hi Manfred, > >> > >> On Mon, Apr 21, 2014 at 4:26 PM, Manfred Spraul > >> wrote: > >> > Hi all, > >> > > >> > the increase of SHMMAX/SHMALL is now a 4 patch series. > >> > I don't have ideas how to improve it further. > >> > >> On the assumption that your patches are heading to mainline, could you > >> send me a man-pages patch for the changes? > > > > Btw, I think that the code could still use some love wrt documentation. > > (Agreed.) > > > Andrew, please consider this for -next if folks agree. Thanks. > > > > 8<---------------------------------------------------------- > > > > From: Davidlohr Bueso > > Subject: [PATCH] ipc,shm: document new limits in the uapi header > > > > This is useful in the future and allows users to > > better understand the reasoning behind the changes. > > > > Also use UL as we're dealing with it anyways. > > > > Signed-off-by: Davidlohr Bueso > > --- > > include/uapi/linux/shm.h | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h > > index 74e786d..e37fb08 100644 > > --- a/include/uapi/linux/shm.h > > +++ b/include/uapi/linux/shm.h > > @@ -8,17 +8,19 @@ > > #endif > > > > /* > > - * SHMMAX, SHMMNI and SHMALL are upper limits are defaults which can > > Something is wrong in the line above (missing word(s)?) ("are upper > limits are defaults") > > > - * be modified by sysctl. > > + * SHMMNI, SHMMAX and SHMALL are the default upper limits which can be > > + * modified by sysctl. Both SHMMAX and SHMALL have their default values > > + * to the maximum limit which is as large as it can be without helping > > + * userspace overflow the values. There is really nothing the kernel > > + * can do to avoid this any variables. It is therefore not advised to > > Something is missing in that last line. > > > + * make them any larger. This is suitable for both 32 and 64-bit systems. > > "This" is not so clear. I suggest replacing with an actual noun. Good point. Perhaps 'These values are ...' would do instead. Thanks, Davidlohr