From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbaEFX3n (ORCPT ); Tue, 6 May 2014 19:29:43 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:62704 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbaEFX3l (ORCPT ); Tue, 6 May 2014 19:29:41 -0400 Message-ID: <1399418979.15399.107.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 08/24] net, diet: Make TCP metrics optional From: Eric Dumazet To: Andi Kleen Cc: Richard Cochran , josh@joshtriplett.org, David Miller , andi@firstfloor.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tom.zanussi@linux.intel.com Date: Tue, 06 May 2014 16:29:39 -0700 In-Reply-To: <20140506210549.GR19657@tassilo.jf.intel.com> References: <20140506032114.GP2382@two.firstfloor.org> <20140505.232327.578134514220748085.davem@davemloft.net> <20140506155703.GA20391@cloud> <20140506.115941.428706504757835279.davem@davemloft.net> <20140506164108.GA20536@cloud> <20140506191447.GB4137@netboy> <20140506195049.GO19657@tassilo.jf.intel.com> <20140506200738.GA17813@netboy> <20140506210549.GR19657@tassilo.jf.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-05-06 at 14:05 -0700, Andi Kleen wrote: > - Make GRO optional. > This is purely a performance feature for high bandwidth. Make this properly then, instead of relying on LTO. We did preliminary work to put this stuff in separate files, but its not complete yet. tcpv4_offload has pointers to tcp4_gro_receive() and tcp4_gro_complete() Is LTO smart enough to understand this will never be called, and do proper code elimination of whole _gro_ helpers ?