From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dan Streetman <ddstreet@ieee.org>,
Fabian Frederick <fabf@skynet.be>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] plist: replace pr_debug with printk in plist_test()
Date: Wed, 07 May 2014 11:37:04 -0700 [thread overview]
Message-ID: <1399487824.2911.28.camel@joe-AO725> (raw)
In-Reply-To: <20140507141956.4eb6ff8d@gandalf.local.home>
On Wed, 2014-05-07 at 14:19 -0400, Steven Rostedt wrote:
> On Wed, 07 May 2014 11:10:38 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > On Wed, 2014-05-07 at 10:35 -0400, Steven Rostedt wrote:
> > > On Wed, 7 May 2014 10:21:28 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> >
> > > > It would be even better if the note could clarify that sometimes it is
> > > > ok to use printk(KERN_DEBUG
> > >
> > > Exactly. I think it's rather stupid to have to do a #define DEBUG to
> > > have pr_debug() print in general.
> > >
> > > I see no reason to have pr_debug() be anything different than the other
> > > pr_*() functions.
> >
> > pr_debug is meant to be disabled and have _no_ runtime
> > effect unless DEBUG is #defined.
>
> I understand why it does it, but having pr_debug() named just like
> pr_info(), pr_notice(), pr_warning(), pr_err(), pr_crit(), pr_alert(),
> pr_emerg(), where all those are just printk(<LOGLEVEL>...) *except* for
> pr_debug(). That's inconsistent and wrong.
>
> pr_debug() should have been just printk(KERN_DEBUG ...) as that follows
> convention.
The convention history is kind of inverted.
As you probably know, all the other pr_<level>
macros other than pr_info were added some years
after pr_debug.
> Yes, it's somewhat too late as pr_debug() is all over the place, but
> maybe when things slow down (Ha! like that will ever happen ... "are we
> done yet?"), then we could do a massive clean up and rename pr_debug()
> to something not so confusing in its usage compared to the other pr_*()
> prints.
g'luck with that.
Renaming pr_warning to pr_warn has taken 4 years
and it's only a 2:1 ratio in favor of pr_warn and
there are _more_ uses of pr_warning today than when
pr_warn was introduced. (1006 to 773)
cheers, Joe
prev parent reply other threads:[~2014-05-07 18:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 20:23 [PATCH] plist: include -DDEBUG if CONFIG_DEBUG_PI_LIST Dan Streetman
2014-05-02 20:41 ` Steven Rostedt
2014-05-05 14:35 ` Dan Streetman
2014-05-05 14:43 ` [PATCH] plist: replace pr_debug with printk in plist_test() Dan Streetman
2014-05-05 14:52 ` Steven Rostedt
2014-05-05 20:35 ` Andrew Morton
2014-05-05 20:52 ` Joe Perches
2014-05-06 12:30 ` Dan Streetman
2014-05-06 15:08 ` [PATCH] Documentation: expand/clarify debug documentation Dan Streetman
2014-05-06 15:44 ` [PATCH] plist: replace pr_debug with printk in plist_test() Fabian Frederick
2014-05-07 14:21 ` Dan Streetman
2014-05-07 14:35 ` Steven Rostedt
2014-05-07 18:10 ` Joe Perches
2014-05-07 18:19 ` Steven Rostedt
2014-05-07 18:37 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399487824.2911.28.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=ddstreet@ieee.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).