Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.

[Sudeep Dutt <sudeep.dutt@intel.com>]

On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote:
> On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote:
> > I am sending all these patches to char-misc because there is a dependency
> > between the patches for dma driver and other drivers.
> > 
> Greg, any feedback on the patches?

Hi Greg,
The primary author of this patch series Siva is no longer with Intel so
we will be taking ownership of addressing review feedback.

The patches have been applied to the MIC GITHUB tree which is registered
with Fengguang Wu's 0-day infrastructure and no issues have been
reported.

We have not received any feedback on the patches yet and were wondering
if you had a chance to review them?

Thanks,
Sudeep Dutt

> > Description:
> > ============
> > This set of patches add support for MIC X100 dma driver.
> > MIC PCIe card has a dma controller with 8 channels. These channels are
> > shared between the host s/w and the card s/w. 0 to 3 are used by host
> > and 4 to 7 by card. As the dma device doesn't show up as PCIe device,
> > a virtual bus called mic bus is created and virtual dma devices are
> > created on it by the host/card drivers. On host the channels are private
> > and used only by the host driver to transfer data for the virtio devices.
> > 
> > Here is a higher level block diagram.
> > 				      |
> > 	       +----------+           |             +----------+
> > 	       | Card OS  |           |             | Host OS  |
> > 	       +----------+           |             +----------+
> > 				      |
> > 	+-------+ +--------+ +------+ | +---------+  +--------+ +--------+
> > 	| Virtio| |Virtio  | |Virtio| | |Virtio   |  |Virtio  | |Virtio  |
> > 	| Net   | |Console | |Block | | |Net      |  |Console | |Block   |
> > 	| Driver| |Driver  | |Driver| | |backend  |  |backend | |backend |
> > 	+-------+ +--------+ +------+ | +---------+  +--------+ +--------+
> > 	    |         |         |     |      |            |         |
> > 	    |         |         |     |User  |            |         |
> > 	    |         |         |     |------|------------|---------|-------
> > 	    +-------------------+     |Kernel +--------------------------+
> > 		      |               |       | Virtio over PCIe IOCTLs  |
> > 		      |               |       +--------------------------+
> > +-----------+	      |               |	    		  |  +-----------+
> > | MIC DMA   |	      |               | 		  |  | MIC DMA	 |
> > | Driver    |         |               |	  		  |  | Driver	 |
> > +-----------+         |               |			  |  +-----------+
> >       |		      |	   	      |			  |	   |
> > +---------------+     |		      |			  |  +----------------+
> > |MIC virtual Bus|     |	 	      |			  |  |MIC virtual Bus |
> > +---------------+     |		      |			  |  +----------------+
> >       |               |               |                   |		 |
> >       |   +--------------+	      |            +---------------+     |
> >       |   |Intel MIC     |	      |            |Intel MIC      |     |
> >       +---|Card Driver   |            |            |Host Driver    |     |
> > 	  +--------------+            |            +---------------+-----+
> > 		      |               |                   |
> > 	     +-------------------------------------------------------------+
> > 	     |                                                             |
> > 	     |                    PCIe Bus                                 |
> > 	     +-------------------------------------------------------------+
> > 
> > The following series of patches are partitioned as follows:
> > 
> > Patch 1: Add mic bus and dma driver documentation.
> > 	 Author: Siva Yerramreddy
> > Patch 2: Add a bus driver for virtual MIC devices.
> > 	 Authors: Siva Yerramreddy, Sudeep Dutt
> > Patch 3: MIC X100 DMA Driver.
> > 	 Author: Siva Yerramreddy
> > Patch 4: Add threaded irq support in host driver.
> > 	 This is needed as the dma driver uses threaded irq.
> > 	 Author: Siva Yerramreddy
> > Patch 5: Add dma support in host driver.
> > 	 Authors: Siva Yerramreddy, Ashutosh Dixit, Sudeep Dutt
> > Patch 6: Add threaded irq support in card driver.
> > 	 This is needed as the dma driver uses threaded irq.
> > 	 Author: Siva Yerramreddy
> > Patch 7: Add dma support in card driver.
> > 	 Author: Siva Yerramreddy
> > Patch 8: Add support for loading/unloading dma driver.
> > 	 Author: Siva Yerramreddy
> > 
> > The patches have been compiled/validated against v3.14.
> > Tested using dmatest module with module parameter "threads_per_chan=60".
> > 
> > Thanks to Dan Williams, Vinod Koul, Jon Mason, Dave Jiang for the initial
> > review.
> > 
> > Siva Yerramreddy (8):
> >   misc: mic: Add mic bus and dma driver documentation
> >   misc: mic: add a bus driver for virtual MIC devices
> >   dma: MIC X100 DMA Driver
> >   misc: mic: add threaded irq support in host driver
> >   misc: mic: add dma support in host driver
> >   misc: mic: add threaded irq support in card driver
> >   misc: mic: add dma support in card driver
> >   misc: mic: add support for loading/unloading dma driver
> > 
> >  Documentation/mic/mic_overview.txt |  67 ++--
> >  Documentation/mic/mpssd/mpss       |  14 +-
> >  drivers/dma/Kconfig                |  19 +
> >  drivers/dma/Makefile               |   1 +
> >  drivers/dma/mic_x100_dma.c         | 774 +++++++++++++++++++++++++++++++++++++
> >  drivers/dma/mic_x100_dma.h         | 286 ++++++++++++++
> >  drivers/misc/mic/Kconfig           |  21 +-
> >  drivers/misc/mic/Makefile          |   1 +
> >  drivers/misc/mic/bus/Makefile      |   5 +
> >  drivers/misc/mic/bus/mic_bus.c     | 188 +++++++++
> >  drivers/misc/mic/card/mic_device.c |  21 +-
> >  drivers/misc/mic/card/mic_device.h |   8 +-
> >  drivers/misc/mic/card/mic_virtio.c |   4 +-
> >  drivers/misc/mic/card/mic_x100.c   |  52 ++-
> >  drivers/misc/mic/host/mic_boot.c   |  78 +++-
> >  drivers/misc/mic/host/mic_device.h |  24 ++
> >  drivers/misc/mic/host/mic_intr.c   | 116 +++---
> >  drivers/misc/mic/host/mic_intr.h   |  21 +-
> >  drivers/misc/mic/host/mic_main.c   |   5 +-
> >  drivers/misc/mic/host/mic_virtio.c | 185 +++++++--
> >  drivers/misc/mic/host/mic_virtio.h |  21 +-
> >  drivers/misc/mic/host/mic_x100.c   |   8 +
> >  include/linux/mic_bus.h            | 148 +++++++
> >  23 files changed, 1922 insertions(+), 145 deletions(-)
> >  create mode 100644 drivers/dma/mic_x100_dma.c
> >  create mode 100644 drivers/dma/mic_x100_dma.h
> >  create mode 100644 drivers/misc/mic/bus/Makefile
> >  create mode 100644 drivers/misc/mic/bus/mic_bus.c
> >  create mode 100644 include/linux/mic_bus.h
> > 
> 
>