From: Michal Marek <mmarek@suse.cz>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v2 5/5] kbuild: Use relative path when building in a subdir of the source tree
Date: Fri, 9 May 2014 14:52:24 +0200 [thread overview]
Message-ID: <1399639944-20551-6-git-send-email-mmarek@suse.cz> (raw)
In-Reply-To: <1399639944-20551-1-git-send-email-mmarek@suse.cz>
When doing make O=<subdir>, use '..' to refer to the source tree. This
allows for more readable compiler messages, and, more importantly, it
sets the VPATH to '..', so filenames in WARN_ON() etc. will be shorter.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
v1->v2: No changes
Makefile | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 4da1c4b..9872c53 100644
--- a/Makefile
+++ b/Makefile
@@ -153,7 +153,17 @@ else
_all: modules
endif
-srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),.)
+ifeq ($(KBUILD_SRC),)
+ # building in the source tree
+ srctree := .
+else
+ ifeq ($(KBUILD_SRC)/,$(dir $(CURDIR)))
+ # building in a subdirectory of the source tree
+ srctree := ..
+ else
+ srctree := $(KBUILD_SRC)
+ endif
+endif
objtree := .
src := $(srctree)
obj := $(objtree)
--
1.8.4.5
prev parent reply other threads:[~2014-05-09 12:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:52 [PATCH v2 0/5] kbuild: Use relative paths if possible Michal Marek
2014-05-09 12:52 ` [PATCH v2 1/5] firmware: Simplify directory creation Michal Marek
2014-05-09 16:51 ` Sam Ravnborg
2014-05-14 20:53 ` Michal Marek
2014-05-09 12:52 ` [PATCH v2 2/5] firmware: Use $(quote) in the Makefile Michal Marek
2014-05-09 12:52 ` [PATCH v2 3/5] kbuild: Use relative path for $(objtree) Michal Marek
2014-06-04 9:03 ` Richard Weinberger
2014-06-04 9:43 ` Michal Marek
2014-06-04 13:12 ` Michal Marek
2014-06-05 15:56 ` Michal Marek
2014-06-09 21:12 ` Michal Marek
2014-06-09 21:23 ` Randy Dunlap
2014-06-09 22:14 ` Michal Marek
2014-06-09 22:24 ` Randy Dunlap
2014-06-09 22:39 ` Michal Marek
2014-06-09 23:47 ` Randy Dunlap
2014-06-10 9:02 ` Michal Marek
2014-06-10 14:09 ` Randy Dunlap
2014-06-10 14:30 ` Michal Marek
2014-06-10 7:40 ` Geert Uytterhoeven
2014-06-10 8:17 ` Michal Marek
2017-10-16 10:26 ` Geert Uytterhoeven
2017-10-16 10:28 ` Geert Uytterhoeven
2017-10-25 12:21 ` Masahiro Yamada
2014-05-09 12:52 ` [PATCH v2 4/5] kbuild: Use relative path when building in the source tree Michal Marek
2014-05-09 12:52 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399639944-20551-6-git-send-email-mmarek@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).