From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D41C282C3 for ; Tue, 22 Jan 2019 16:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C12921726 for ; Tue, 22 Jan 2019 16:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729301AbfAVQae (ORCPT ); Tue, 22 Jan 2019 11:30:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728580AbfAVQad (ORCPT ); Tue, 22 Jan 2019 11:30:33 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F30A2ED3C1; Tue, 22 Jan 2019 16:30:32 +0000 (UTC) Received: from [10.18.17.208] (dhcp-17-208.bos.redhat.com [10.18.17.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9419268897; Tue, 22 Jan 2019 16:30:31 +0000 (UTC) Subject: Re: [PATCH V2] livepatch: fix non-static warnings From: Joe Lawrence To: Nicholas Mc Guire Cc: Miroslav Benes , Josh Poimboeuf , Jessica Yu , Jiri Kosina , Petr Mladek , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <1544965657-26804-1-git-send-email-hofrat@osadl.org> <20ef1d3a-2916-ce00-2938-3397746efac9@redhat.com> Message-ID: <13b0bd3d-1441-b83b-bee3-d5fc666a9d26@redhat.com> Date: Tue, 22 Jan 2019 11:30:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 22 Jan 2019 16:30:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/18 10:18 AM, Joe Lawrence wrote: > On 12/18/2018 03:49 AM, Miroslav Benes wrote: >> On Mon, 17 Dec 2018, Joe Lawrence wrote: >> >>> I'm just being picky about its documentation and how we should note its >>> usage in the v3 patch. Think that s/__noclone/used/g of the v2 commit >>> message would be sufficient? >> >> We could rephrase it. After all it is not only about symbol names in the >> symbol table. The traceable/patchable code has to be present... >> >> "Sparse reported warnings about non-static symbols. For the variables >> a simple static attribute is fine - for the functions referenced by >> livepatch via klp_func the symbol-names must be unmodified in the >> symbol table and the patchable code has to be emitted. >> >> Attach __used attribute to the shared statically declared functions." >> >> ? > > That works for me. > Hi Nicholas, Did you still want to post a v3 for this fix? I think there were only a few v3 suggestions (link tag, tag order, __used attribute, and commit msg phrasing.) The context has been clipped in the quoting above, so here's an archive link if you need it: https://lore.kernel.org/lkml/1544965657-26804-1-git-send-email-hofrat@osadl.org/ Thanks, -- Joe